From: Ashok Raj <ashok.raj@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: X86-kernel <x86@kernel.org>,
LKML Mailing List <linux-kernel@vger.kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
"Tony Luck" <tony.luck@intel.com>, <alison.schofield@intel.com>,
<reinette.chatre@intel.com>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Patch V1 2/7] x86/microcode/intel: Remove retries on early microcode load
Date: Mon, 5 Dec 2022 08:42:10 -0800 [thread overview]
Message-ID: <Y44fYl4oV5HmtjJM@a4bf019067fa.jf.intel.com> (raw)
In-Reply-To: <Y43hstW6oL4naReu@zn.tnic>
On Mon, Dec 05, 2022 at 01:18:58PM +0100, Borislav Petkov wrote:
> On Tue, Nov 29, 2022 at 01:08:27PM -0800, Ashok Raj wrote:
> > There is no direct evidence that these end user issues were caused by this
> > retry loop. However, the early boot hangs along with reverting the
> > microcode update workaround provide strong circumstantial evidence to
> > support the theory that they are linked.
>
> A "circumstantial" reason for why something "might" be broken has no
> place in a commit message.
>
> If you still wanna chase this and *actually* give me a sane,
> comprehensible reason of why this could cause an endless loop with
> officially released microcode, then I'm willing to listen.
Your changes look fine, thanks for fixing it up.
>
> Otherwise, I'll apply this:
>
Cheers,
Ashok
next prev parent reply other threads:[~2022-12-05 16:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 21:08 [Patch V1 0/7] x86/microcode: Some cleanups and fixes for microcode Ashok Raj
2022-11-29 21:08 ` [Patch V1 1/7] x86/microcode/intel: Remove redundant microcode rev pr_info()s Ashok Raj
2022-12-02 18:58 ` Thomas Gleixner
2022-12-03 0:26 ` Ashok Raj
2022-12-03 13:42 ` Borislav Petkov
2022-11-29 21:08 ` [Patch V1 2/7] x86/microcode/intel: Remove retries on early microcode load Ashok Raj
2022-12-02 19:01 ` Thomas Gleixner
2022-12-03 1:48 ` Ashok Raj
2022-12-02 23:53 ` Sohil Mehta
2022-12-03 1:47 ` Ashok Raj
2022-12-05 12:18 ` Borislav Petkov
2022-12-05 16:42 ` Ashok Raj [this message]
2022-12-05 20:53 ` [tip: x86/microcode] x86/microcode/intel: Do not retry microcode reloading on the APs tip-bot2 for Ashok Raj
2022-11-29 21:08 ` [Patch V1 3/7] x86/microcode/core: Move microcode_check() to cpu/microcode/core.c Ashok Raj
2022-12-02 19:02 ` Thomas Gleixner
2022-12-02 20:57 ` Sohil Mehta
2022-12-03 0:21 ` Ashok Raj
2022-12-05 16:25 ` Borislav Petkov
2022-12-05 17:05 ` Ashok Raj
2022-12-05 21:27 ` Borislav Petkov
2022-11-29 21:08 ` [Patch V1 4/7] x86/microcode/core: Take a snapshot before and after applying microcode Ashok Raj
2022-12-02 19:09 ` Thomas Gleixner
2022-12-03 1:57 ` Ashok Raj
2022-12-07 20:25 ` Borislav Petkov
2022-12-08 0:05 ` Ashok Raj
2022-11-29 21:08 ` [Patch V1 5/7] x86/microcode/intel: Prepare the print_ucode_rev to simply take a rev to print Ashok Raj
2022-12-02 19:23 ` Thomas Gleixner
2022-11-29 21:08 ` [Patch V1 6/7] x86/microcode/intel: Print old and new rev during early boot Ashok Raj
2022-12-02 19:29 ` Thomas Gleixner
2022-11-29 21:08 ` [Patch V1 7/7] x86/microcode/intel: Print when early microcode loading fails Ashok Raj
2022-12-02 19:30 ` Thomas Gleixner
2022-12-05 18:19 ` Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y44fYl4oV5HmtjJM@a4bf019067fa.jf.intel.com \
--to=ashok.raj@intel.com \
--cc=alison.schofield@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox