From: Jason Gunthorpe <jgg@nvidia.com>
To: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
Cc: "zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
"leon@kernel.org" <leon@kernel.org>,
Bob Pearson <rpearsonhpe@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Mark Bloch <mbloch@nvidia.com>, Tom Talpey <tom@talpey.com>,
"tomasz.gromadzki@intel.com" <tomasz.gromadzki@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
"yangx.jy@fujitsu.com" <yangx.jy@fujitsu.com>,
"Yasunori Gotou (Fujitsu)" <y-goto@fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [for-next PATCH v6 09/10] RDMA/cm: Make QP FLUSHABLE
Date: Mon, 5 Dec 2022 13:12:55 -0400 [thread overview]
Message-ID: <Y44ml2qsQkx+QNRs@nvidia.com> (raw)
In-Reply-To: <3d2b0f6d-6214-8d04-8356-852c34563501@fujitsu.com>
On Mon, Dec 05, 2022 at 10:07:11AM +0000, lizhijian@fujitsu.com wrote:
> diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> index 1f9938a2c475..603c0aecc361 100644
> --- a/drivers/infiniband/core/cm.c
> +++ b/drivers/infiniband/core/cm.c
> @@ -4094,9 +4094,18 @@ static int cm_init_qp_init_attr(struct cm_id_private *cm_id_priv,
> *qp_attr_mask = IB_QP_STATE | IB_QP_ACCESS_FLAGS |
> IB_QP_PKEY_INDEX | IB_QP_PORT;
> qp_attr->qp_access_flags = IB_ACCESS_REMOTE_WRITE;
> - if (cm_id_priv->responder_resources)
> + if (cm_id_priv->responder_resources) {
> + struct ib_device *ib_dev = cm_id_priv->id.device;
> + u64 support_flush = ib_dev->attrs.device_cap_flags &
> + (IB_DEVICE_FLUSH_GLOBAL | IB_DEVICE_FLUSH_PERSISTENT);
> + u32 flushable = support_flush ?
> + (IB_ACCESS_FLUSH_GLOBAL |
> + IB_ACCESS_FLUSH_PERSISTENT) : 0;
> +
> qp_attr->qp_access_flags |= IB_ACCESS_REMOTE_READ |
> - IB_ACCESS_REMOTE_ATOMIC;
> + IB_ACCESS_REMOTE_ATOMIC |
> + flushable;
> + }
This makes more sense
Jason
next prev parent reply other threads:[~2022-12-05 17:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 8:19 [for-next PATCH v6 00/10] RDMA/rxe: Add RDMA FLUSH operation Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 01/10] RDMA: Extend RDMA user ABI to support flush Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 02/10] RDMA: Extend RDMA kernel verbs " Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 03/10] RDMA/rxe: Extend rxe user " Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 04/10] RDMA/rxe: Allow registering persistent flag for pmem MR only Li Zhijian
2022-11-22 14:46 ` Jason Gunthorpe
2022-11-23 6:12 ` lizhijian
2022-11-16 8:19 ` [for-next PATCH v6 05/10] RDMA/rxe: Extend rxe packet format to support flush Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 06/10] RDMA/rxe: Implement RC RDMA FLUSH service in requester side Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 07/10] RDMA/rxe: Implement flush execution in responder side Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 08/10] RDMA/rxe: Implement flush completion Li Zhijian
2022-11-16 8:19 ` [for-next PATCH v6 09/10] RDMA/cm: Make QP FLUSHABLE Li Zhijian
2022-11-22 14:52 ` Jason Gunthorpe
2022-11-23 6:07 ` lizhijian
2022-11-24 17:39 ` Jason Gunthorpe
2022-11-25 2:22 ` lizhijian
2022-11-25 14:16 ` Jason Gunthorpe
2022-11-28 10:23 ` lizhijian
2022-12-05 10:07 ` lizhijian
2022-12-05 17:12 ` Jason Gunthorpe [this message]
2022-12-07 1:25 ` lizhijian
2022-11-16 8:19 ` [for-next PATCH v6 10/10] RDMA/rxe: Enable RDMA FLUSH capability for rxe device Li Zhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y44ml2qsQkx+QNRs@nvidia.com \
--to=jgg@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=mbloch@nvidia.com \
--cc=rpearsonhpe@gmail.com \
--cc=tom@talpey.com \
--cc=tomasz.gromadzki@intel.com \
--cc=y-goto@fujitsu.com \
--cc=yangx.jy@fujitsu.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox