From: David Vernet <void@manifault.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>, F@maniforge.lan
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
yhs@meta.com, john.fastabend@gmail.com, kpsingh@kernel.org,
sdf@google.com, haoluo@google.com, jolsa@kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH bpf-next 1/2] bpf/docs: Document struct task_struct * kfuncs
Date: Mon, 5 Dec 2022 14:58:22 -0600 [thread overview]
Message-ID: <Y45bbn+5vDPgM12z@maniforge.lan> (raw)
In-Reply-To: <Y44X5uQ0tJoCvQ96@maniforge.lan>
On Mon, Dec 05, 2022 at 10:10:14AM -0600, David Vernet wrote:
> > > +.. code-block:: c
> > > +
> > > + SEC("tp_btf/task_newtask")
> > > + int BPF_PROG(task_get_pid_example, struct task_struct *task, u64 clone_flags)
> > > + {
> > > + struct task_struct *lookup;
> > > +
> > > + lookup = bpf_task_from_pid(task->pid);
> > > + if (!lookup)
> > > + /* A task should always be found, as %task is a tracepoint arg. */
> > > + return -ENOENT;
> > > +
> > > + if (lookup->pid != task->pid) {
> > > + /* The pid of the lookup task should be the same as the input task. */
> >
> > I suspect both "errors" are actually possible in practice,
> > since bpf_task_from_pid is using init_pid_ns.
> > But this taskd might be in different pid_ns. See task_active_pid_ns.
> > Probably worth mentioning this aspect of bpf_task_from_pid.
>
> Yep, agreed. Will add
Actually, I don't think either error can ever happen. p->pid is globally
unique, and always uses the init_pid_ns. See [0] where p->pid is set,
and [1] for the implementation of pid_nr(). So I think the existing
example is actually correct, though I'll still add some comments to
explain that the kfunc only works for p->pid / the init_pid_ns.
[0]: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/tree/kernel/fork.c#n2326
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/tree/include/linux/pid.h#n181
next prev parent reply other threads:[~2022-12-05 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 22:07 [PATCH bpf-next 0/2] Document some recent core kfunc additions David Vernet
2022-12-02 22:07 ` [PATCH bpf-next 1/2] bpf/docs: Document struct task_struct * kfuncs David Vernet
2022-12-03 2:15 ` Alexei Starovoitov
2022-12-05 16:10 ` David Vernet
2022-12-05 20:58 ` David Vernet [this message]
2022-12-02 22:07 ` [PATCH bpf-next 2/2] bpf/docs: Document struct cgroup " David Vernet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y45bbn+5vDPgM12z@maniforge.lan \
--to=void@manifault.com \
--cc=F@maniforge.lan \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox