From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 9C464C352A1
	for <linux-kernel@archiver.kernel.org>; Tue,  6 Dec 2022 08:05:33 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232414AbiLFIFb (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 6 Dec 2022 03:05:31 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41456 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230230AbiLFIF0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Dec 2022 03:05:26 -0500
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 777711A07B;
        Tue,  6 Dec 2022 00:05:25 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id F1D10615A5;
        Tue,  6 Dec 2022 08:05:24 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 801B2C433C1;
        Tue,  6 Dec 2022 08:05:23 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1670313924;
        bh=iU1nTlIIFsG8ZExX8X4Ya6XC5By7z1nDy14hkZt+HlQ=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=FOkFwdZ9ZIcz3j3JA396Ocj7KcLySwy0uvUe0vny0Pbrw2dintYZnayHReK1EhVQi
         Pa8y7fcxDDBECOkCEY3j8aoNT7/YQ8K2nsdKCzMCYiJo0I9rBrTPLr7Pbzh7fQGkNm
         JxzWLkT/jo1gRaGKdZco+3/Ik4bou2vxG6PlfhjQwx9jOGjIB/qBIH31US0kZBpu02
         NRccyX7ouPX3bCi18DxAG5Gt3MiQBRHKIsIXzGwtvFr0iinYX5Vu7RSlICr9NI4Wjr
         hNfR2L5oVFmbd2ymCn799tjukAvqYSY5KYl/pRpYPrvtHX0itxybvgIpwvhaWw6Zwb
         a09pbej5VmOpA==
Date:   Tue, 6 Dec 2022 10:05:19 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     ye.xingchen@zte.com.cn
Cc:     edumazet@google.com, davem@davemloft.net, kuba@kernel.org,
        pabeni@redhat.com, richardbgobert@gmail.com, iwienand@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: use sysfs_emit() to instead of
 scnprintf()
Message-ID: <Y473v/0z/YlTRzoT@unreal>
References: <202212051918564721658@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202212051918564721658@zte.com.cn>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 05, 2022 at 07:18:56PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
> 
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>  net/ethernet/eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>