From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB64C3A5A7 for ; Tue, 6 Dec 2022 06:28:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233449AbiLFG2d (ORCPT ); Tue, 6 Dec 2022 01:28:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229936AbiLFG21 (ORCPT ); Tue, 6 Dec 2022 01:28:27 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B84F92715C; Mon, 5 Dec 2022 22:28:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zvJHRg8epOGP7B5mR8RnlBGi9TRfSPxBhBQXSLBakps=; b=DOU8MPSo4/6Yazfa2uAn8wzXSS eFsmLNzVCEYxo5MoDVzwF2EepzbtjgG3Uj8csdjHne35+YBCYYXFH6WOnvTzHKZQNf25x06nyWsz5 Hy5306ZvwyeXOSQ8GjrtnL/G/5wvYtKutyu17uvfXmKTF5cOCKuv51k2F7qyYJ8CLHj1fWvaDTHkP LN9nyRPZCXa2+qv688B642E7P97BNxw7Jl+rktMfTWym9G8fOII5Y/FoR1mn474mGflPHSrPyKKEw XWsgUkFvndIeYNrKBxJ5bMGsIWXZJOWztZscwkmNzxDeIs+EMZebJsdRko/nTwfiNulIRVsaWOYjE b66gqmfg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2RQs-0026iT-33; Tue, 06 Dec 2022 06:27:58 +0000 Date: Mon, 5 Dec 2022 22:27:58 -0800 From: Christoph Hellwig To: Herbert Xu Cc: Christoph Hellwig , Catalin Marinas , Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , LinuxKernelMailingList@gondor.apana.org.au, linux-kernel@vger.kernel.org, "David S. Miller" , Linux Crypto Mailing List Subject: Re: [PATCH 0/10] crypto: Driver conversions for DMA alignment Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 06, 2022 at 12:13:52PM +0800, Herbert Xu wrote: > Yes they're clearly bogus. Basically they are saying they want > memory that is aligned sufficiently for DMA. So if Catalin's > patch-set will break this assumption, then all the GFP_DMA allocations > in drivers/crypto will need to be enlarged to take this into > account. But GFP_DMA never did do anything at all about alignment. It picks allocations from ZONE_DMA (which on x86 is the first 16MB only).