From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6931AC4332F for ; Fri, 25 Nov 2022 04:09:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229657AbiKYEJb (ORCPT ); Thu, 24 Nov 2022 23:09:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbiKYEJ0 (ORCPT ); Thu, 24 Nov 2022 23:09:26 -0500 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6692C21E01; Thu, 24 Nov 2022 20:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dhcCjaJ57IsbkqSUTzblE3Oegbl0RdETkw+TxczXs2o=; b=DCfYm8tP3312DF88DmAxxJkMHK OPNDqWf+GWrd7eM6AiDwT5jVSQrgxVs//5FMqENYi8QqpoRy34Qjtu0Cea4NMTohQNykElKKlk667 LbodGSP0owEIB7D5tBEHZoFwoiFlHGCFxBGzuJ+WYwNJjNEvWaVoPwZWmAyq+qI/iG/UU7zxlfN0u sq44/Ivv8twQDYsYak2ylZ9+Wx1zVZvNOfvY20hnCa0+KPjoMicOfJzyxDDbTHx9CC/BGxvlVIxIr clV7jsaxmrD1QtfIUIjJq1WNKmjg4u0lXVJRBbZZRe9Hu483FzPqBWAR4vAF+do05PW/qR0bFNQU0 ChfJ7fAA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1oyQ1h-006aTm-1R; Fri, 25 Nov 2022 04:09:21 +0000 Date: Fri, 25 Nov 2022 04:09:21 +0000 From: Al Viro To: Miklos Szeredi Cc: Thorsten Leemhuis , Linux-fsdevel , "regressions@lists.linux.dev" , LKML , "Christian Brauner (Microsoft)" , Pierre Labastie , linux-unionfs@vger.kernel.org Subject: Re: [regression, bisected] Bug 216738 - Adding O_APPEND to O_RDWR with fcntl(fd, F_SETFL) does not work on overlayfs Message-ID: References: <2505800d-8625-dab0-576a-3a0221954ba3@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 24, 2022 at 09:33:54PM +0100, Miklos Szeredi wrote: > > I could pick it in vfs.git #fixes, or Miklos could put it through his tree. > > Miklos, which way would you prefer that to go? > > I'll pick this into #overlayfs-next, as a PR for this cycle is needed anyway. OK... FWIW, I wonder if exposing setfl() would and using it instead of open-coding would be a good idea - these two are very close to each other...