From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7EDFC4167D for ; Fri, 25 Nov 2022 11:01:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230346AbiKYLBi (ORCPT ); Fri, 25 Nov 2022 06:01:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230334AbiKYLBf (ORCPT ); Fri, 25 Nov 2022 06:01:35 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5C674A9D9; Fri, 25 Nov 2022 03:01:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669374094; x=1700910094; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=omfNsrNIaeP/xU1KSWpTZU7Q1phlc5HugKhhDzBoTfI=; b=QNAhmi5i6hg1u4rMCQLB5Ptd1j+RfQMeAyZNTIn6IJYQ+i+Kw+rLGHsj inLLFC7iJJGp0iNBhfUMjjCqVNUvFMT4jtRXsWVnepOG0VEzXoiamY5ad xs4YSH7+ks3n1YvcCSvvsOmhee1S+PtQL5ZbCbaERpzE+UXRDuA4v7oSW BvoNFDFENqgNrV8mzteVMKZ+3daA382nrcQ1KAx5BLCCPxB21gWBGBiYy H7dMyuz69x2J85H93UQt4cWUTcFey+JvXkOXNJkgh/aW1cuepLSMK8b9V a13aC5bpo00qNxiHCOF/xLttGxqV0/pIEMcwXt2aaO4OEwJSsvCf77jax A==; X-IronPort-AV: E=McAfee;i="6500,9779,10541"; a="378718283" X-IronPort-AV: E=Sophos;i="5.96,193,1665471600"; d="scan'208";a="378718283" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2022 03:01:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10541"; a="767338871" X-IronPort-AV: E=Sophos;i="5.96,193,1665471600"; d="scan'208";a="767338871" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 25 Nov 2022 03:01:30 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oyWSW-00HCL9-2u; Fri, 25 Nov 2022 13:01:28 +0200 Date: Fri, 25 Nov 2022 13:01:28 +0200 From: Andy Shevchenko To: Gerald Loacker Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Jakob Hauser , Linus Walleij , Nikita Yushchenko , Michael Riesch Subject: Re: [PATCH v3 1/3] iio: add struct declarations for iio types Message-ID: References: <20221125083526.2422900-1-gerald.loacker@wolfvision.net> <20221125083526.2422900-2-gerald.loacker@wolfvision.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 25, 2022 at 12:45:06PM +0200, Andy Shevchenko wrote: > On Fri, Nov 25, 2022 at 09:35:24AM +0100, Gerald Loacker wrote: ... > > +struct iio_val_int_plus_micro { > > + int val_int; > > + int val_micro; > > +}; Thinking more about naming, why not drop val_ completely? int integer; int micro; ? > > +struct iio_val_int_plus_nano { > > + int val_int; > > + int val_nano; > > +}; > > + > > +struct iio_val_int_plus_micro_db { > > + int val_int; > > int val_int_db; ? > > > + int val_micro_db; > > +}; > > Actually why can't we simply do > > typedef iio_val_int_plus_micro_db iio_val_int_plus_micro; > > ? -- With Best Regards, Andy Shevchenko