From: Andrew Lunn <andrew@lunn.ch>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: eajames@linux.ibm.com, mchehab@kernel.org,
linux-media@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
joel@jms.id.au, andrew@aj.id.au
Subject: Re: [PATCH v2] media: aspeed: Fix return value check in aspeed_video_debugfs_create()
Date: Sat, 26 Nov 2022 18:25:07 +0100 [thread overview]
Message-ID: <Y4JL89BCcs1pjWZZ@lunn.ch> (raw)
In-Reply-To: <20221126022813.57372-1-zhengyongjun3@huawei.com>
On Sat, Nov 26, 2022 at 02:28:13AM +0000, Zheng Yongjun wrote:
> In case of error, the function debugfs_create_file() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Fixes: 52fed10ad756 ("media: aspeed: add debugfs")
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Please see:
https://patchwork.kernel.org/project/linux-wireless/patch/20200429101526.GA2094124@kroah.com/
and there are other examples. Just delete all the checks.
Andrew
prev parent reply other threads:[~2022-11-26 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 2:28 [PATCH v2] media: aspeed: Fix return value check in aspeed_video_debugfs_create() Zheng Yongjun
2022-11-26 17:25 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4JL89BCcs1pjWZZ@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox