From: Dan Carpenter <error27@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
harshit.m.mogalapalli@gmail.com, Jason Wang <jasowang@redhat.com>,
Xie Yongji <xieyongji@bytedance.com>,
Gautam Dawar <gautam.dawar@xilinx.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Guanjun <guanjun@linux.alibaba.com>,
Parav Pandit <parav@nvidia.com>, Eli Cohen <elic@nvidia.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vduse: Fix a possible warning in vduse_create_dev()
Date: Mon, 28 Nov 2022 07:13:40 +0300 [thread overview]
Message-ID: <Y4Q1dOgAY3fWuZBn@kadam> (raw)
In-Reply-To: <20221127113416-mutt-send-email-mst@kernel.org>
Btw, after you add the check to vduse_validate_config() you can test
that it silences the Smatch warning by doing:
kchecker --info drivers/vdpa/vdpa_user/vduse_dev.c | tee out
~/smatch/smatch_data/db/reload_partial.sh out
kchecker drivers/vdpa/vdpa_user/vduse_dev.c
You might need to do a second --info and reload for the changes to
propagate.
regards,
dan carpenter
next prev parent reply other threads:[~2022-11-28 4:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 3:59 [PATCH] vduse: Fix a possible warning in vduse_create_dev() Harshit Mogalapalli
2022-11-26 23:22 ` Michael S. Tsirkin
2022-11-27 2:46 ` Harshit Mogalapalli
2022-11-27 16:34 ` Michael S. Tsirkin
2022-11-28 4:13 ` Dan Carpenter [this message]
2022-11-28 8:38 ` Harshit Mogalapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4Q1dOgAY3fWuZBn@kadam \
--to=error27@gmail.com \
--cc=elic@nvidia.com \
--cc=gautam.dawar@xilinx.com \
--cc=guanjun@linux.alibaba.com \
--cc=harshit.m.mogalapalli@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox