From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
kirill.shutemov@linux.intel.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, jpoimboe@kernel.org,
linux-kernel@vger.kernel.org, mingo@redhat.com,
sathyanarayanan.kuppuswamy@linux.intel.com, tglx@linutronix.de,
viro@zeniv.linux.org.uk, x86@kernel.org
Subject: Re: [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from asm-offsets.c
Date: Mon, 28 Nov 2022 18:06:18 +0000 [thread overview]
Message-ID: <Y4T4msSXCNnfPCMG@google.com> (raw)
In-Reply-To: <b98429d8-6d18-cf0b-6ca0-d9d6472d21f9@redhat.com>
On Mon, Nov 28, 2022, Paolo Bonzini wrote:
> On 11/28/22 18:45, Steven Rostedt wrote:
> >
> > > > If you are sure <asm/ftrace.h> is never included from asm-offsets.c,
> > > > remove #ifndef COMPILE_OFFSETS too.
> > > It is never included from asm-offsets.c but it is still used by
> > > kvm-asm-offsets.c:
> > > https://elixir.bootlin.com/linux/v6.1-rc7/source/arch/x86/kvm/kvm-asm-offsets.c#L7
> > IIRC, the reason for adding that was because that logic was screwing up
> > asm-offsets.c. I'm not sure it screws up kvm-asm-offsets.c though.
> >
> > This is one of those cases I wish I commented that code better :-/
>
> I don't think KVM includes linux/ftrace.h or asm/ftrace.h at all.
From include/linux/kvm_host.h
#include <linux/ftrace.h>
Even if that didn't exist, saying that XYZ never includes a header is a dangerous
business, it's all too easy to indirectly include headers in the kernel, now or
in the future.
next prev parent reply other threads:[~2022-11-28 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 6:23 [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from asm-offsets.c Vincent Mailhol
2022-11-28 9:15 ` Kirill A . Shutemov
2022-11-28 10:11 ` Vincent Mailhol
2022-11-28 11:11 ` kirill.shutemov
2022-11-28 11:30 ` Vincent MAILHOL
2022-11-28 17:45 ` Steven Rostedt
2022-11-28 18:00 ` Paolo Bonzini
2022-11-28 18:06 ` Sean Christopherson [this message]
2022-11-28 19:10 ` Steven Rostedt
2022-11-29 10:14 ` Vincent MAILHOL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4T4msSXCNnfPCMG@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox