From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
stable@vger.kernel.org, Dale Smith <dalepsmith@gmail.com>,
John Harris <jmharris@gmail.com>
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Save and restore pins in "direct IRQ" mode
Date: Mon, 28 Nov 2022 21:12:18 +0200 [thread overview]
Message-ID: <Y4UIEpICwI9NdoL+@smile.fi.intel.com> (raw)
In-Reply-To: <Y4BcguSaNlh7VbLQ@black.fi.intel.com>
On Fri, Nov 25, 2022 at 08:11:14AM +0200, Mika Westerberg wrote:
> On Fri, Nov 25, 2022 at 12:29:26AM +0200, Andy Shevchenko wrote:
> > The firmware on some systems may configure GPIO pins to be
> > an interrupt source in so called "direct IRQ" mode. In such
> > cases the GPIO controller driver has no idea if those pins
> > are being used or not. At the same time, there is a known bug
> > in the firmwares that don't restore the pin settings correctly
> > after suspend, i.e. by an unknown reason the Rx value becomes
> > inverted.
> >
> > Hence, let's save and restore the pins that are configured
> > as GPIOs in the input mode with GPIROUTIOXAPIC bit set.
> >
> > Cc: stable@vger.kernel.org
> > Reported-and-tested-by: Dale Smith <dalepsmith@gmail.com>
> > Reported-and-tested-by: John Harris <jmharris@gmail.com>
> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214749
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Thanks Andy!
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thank you!
Linus, this would be nice to have in v6.1 release, if possible.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-28 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 22:29 [PATCH v1 1/1] pinctrl: intel: Save and restore pins in "direct IRQ" mode Andy Shevchenko
2022-11-25 6:11 ` Mika Westerberg
2022-11-28 19:12 ` Andy Shevchenko [this message]
2022-11-28 20:42 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4UIEpICwI9NdoL+@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dalepsmith@gmail.com \
--cc=jmharris@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox