From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF70C352A1 for ; Wed, 30 Nov 2022 10:55:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233212AbiK3KzK (ORCPT ); Wed, 30 Nov 2022 05:55:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232159AbiK3KzI (ORCPT ); Wed, 30 Nov 2022 05:55:08 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C44D18B32; Wed, 30 Nov 2022 02:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669805707; x=1701341707; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IQCNlMQYsfuqqjPfnZdd0e9JtFAPXzKRS8AZMTuMtNs=; b=E9no2U4fDClP2IIupphBodWe1/S5m091axjrdcjCGEMwD0x8dPaHbSlP yjahWjqjrDNC5V1z7eNh5c0kaJQ/jgpWeFfljkvOx6jz6rjw9TacwLsHu q3gLRn+vfG8Ep9ftzAdNMPLV0I5gvfKrTrtXvlSXKAn3KbasqM4KOW7lb ecAkK7ZAe6acOGz0u32D+rF9gFTZ5FgfHm2nTUs1JNijrKZrp5vCrmI4/ nBfkyus22+RaIbPCI3kBaClsGcJKQs/bQKzqZpfqOeQXFToE25PTkAoiT m5bBGSZKURD7YQn4cGXURU8PPm496W0522/dMQaT2U5wn9H/yaC/WysHw Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="342286081" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="342286081" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 02:55:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="786421323" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="786421323" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 30 Nov 2022 02:55:04 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p0Kk2-002Dpc-0W; Wed, 30 Nov 2022 12:55:02 +0200 Date: Wed, 30 Nov 2022 12:55:01 +0200 From: Andy Shevchenko To: Gerald Loacker Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Jakob Hauser , Linus Walleij , Nikita Yushchenko , Michael Riesch Subject: Re: [PATCH v4 3/3] iio: magnetometer: add ti tmag5273 driver Message-ID: References: <20221129064540.3218982-1-gerald.loacker@wolfvision.net> <20221129064540.3218982-4-gerald.loacker@wolfvision.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30, 2022 at 10:04:41AM +0100, Gerald Loacker wrote: > Am 29.11.2022 um 17:37 schrieb Andy Shevchenko: > > On Tue, Nov 29, 2022 at 07:45:40AM +0100, Gerald Loacker wrote: ... > >> + snprintf(data->name, sizeof(data->name), "tmag5273x%1u", data->version); > > > > Thinking more about this format, perhaps > > > > snprintf(data->name, sizeof(data->name), "tmag5273x-v%1u", data->version); > > > > ? > > I'd prefer to keep this as it's related to the orderable part number, > e.g. TMAG5273A1 / TMAG5273A2. I see, can you add a comment above to clarify the chosen format? -- With Best Regards, Andy Shevchenko