From: Leon Romanovsky <leon@kernel.org>
To: cgel.zte@gmail.com
Cc: dennis.dalessandro@cornelisnetworks.com, jgg@ziepe.ca,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Yang <yang.yang29@zte.com.cn>
Subject: Re: [PATCH] IB/hfi1: switch to netif_napi_add()
Date: Wed, 30 Nov 2022 10:40:32 +0200 [thread overview]
Message-ID: <Y4cXAIzTsUVYvfg4@unreal> (raw)
In-Reply-To: <20221129102500.616923-1-yang.yang29@zte.com.cn>
On Tue, Nov 29, 2022 at 10:25:01AM +0000, cgel.zte@gmail.com wrote:
> From: Yang Yang <yang.yang29@zte.com.cn>
>
> There is no need to use netif_napi_add_weight() when the weight argument
> is 64. See "net: drop the weight argument from netif_napi_add".
>
> Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
> ---
> drivers/infiniband/hw/hfi1/netdev_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please send this patch as plain-text with git send-email.
It wasn't recorded in https://lore.kernel.org/linux-rdma/
Thanks
>
> diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
> index 3dfa5aff2512..720d4c85c9c9 100644
> --- a/drivers/infiniband/hw/hfi1/netdev_rx.c
> +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
> @@ -216,7 +216,7 @@ static int hfi1_netdev_rxq_init(struct hfi1_netdev_rx *rx)
> * right now.
> */
> set_bit(NAPI_STATE_NO_BUSY_POLL, &rxq->napi.state);
> - netif_napi_add_weight(dev, &rxq->napi, hfi1_netdev_rx_napi, 64);
> + netif_napi_add(dev, &rxq->napi, hfi1_netdev_rx_napi);
> rc = msix_netdev_request_rcd_irq(rxq->rcd);
> if (rc)
> goto bail_context_irq_failure;
> --
> 2.25.1
>
next parent reply other threads:[~2022-11-30 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221129102500.616923-1-yang.yang29@zte.com.cn>
2022-11-30 8:40 ` Leon Romanovsky [this message]
2022-11-30 9:44 [PATCH] IB/hfi1: switch to netif_napi_add() yang.yang29
2022-12-01 9:10 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4cXAIzTsUVYvfg4@unreal \
--to=leon@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox