* Re: [PATCH] IB/hfi1: switch to netif_napi_add()
[not found] <20221129102500.616923-1-yang.yang29@zte.com.cn>
@ 2022-11-30 8:40 ` Leon Romanovsky
0 siblings, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2022-11-30 8:40 UTC (permalink / raw)
To: cgel.zte; +Cc: dennis.dalessandro, jgg, linux-rdma, linux-kernel, Yang Yang
On Tue, Nov 29, 2022 at 10:25:01AM +0000, cgel.zte@gmail.com wrote:
> From: Yang Yang <yang.yang29@zte.com.cn>
>
> There is no need to use netif_napi_add_weight() when the weight argument
> is 64. See "net: drop the weight argument from netif_napi_add".
>
> Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
> ---
> drivers/infiniband/hw/hfi1/netdev_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please send this patch as plain-text with git send-email.
It wasn't recorded in https://lore.kernel.org/linux-rdma/
Thanks
>
> diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
> index 3dfa5aff2512..720d4c85c9c9 100644
> --- a/drivers/infiniband/hw/hfi1/netdev_rx.c
> +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
> @@ -216,7 +216,7 @@ static int hfi1_netdev_rxq_init(struct hfi1_netdev_rx *rx)
> * right now.
> */
> set_bit(NAPI_STATE_NO_BUSY_POLL, &rxq->napi.state);
> - netif_napi_add_weight(dev, &rxq->napi, hfi1_netdev_rx_napi, 64);
> + netif_napi_add(dev, &rxq->napi, hfi1_netdev_rx_napi);
> rc = msix_netdev_request_rcd_irq(rxq->rcd);
> if (rc)
> goto bail_context_irq_failure;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] IB/hfi1: switch to netif_napi_add()
@ 2022-11-30 9:44 yang.yang29
2022-12-01 9:10 ` Leon Romanovsky
0 siblings, 1 reply; 3+ messages in thread
From: yang.yang29 @ 2022-11-30 9:44 UTC (permalink / raw)
To: dennis.dalessandro, jgg, leon; +Cc: linux-rdma, linux-kernel, yang.yang29
From: Yang Yang <yang.yang29@zte.com.cn>
There is no need to use netif_napi_add_weight() when the weight argument
is 64. See "net: drop the weight argument from netif_napi_add".
Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
Reviewed-by: xu xin <xu.xin16@zte.com.cn>
Reviewed-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
drivers/infiniband/hw/hfi1/netdev_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
index 3dfa5aff2512..08080ca6cb2d 100644
--- a/drivers/infiniband/hw/hfi1/netdev_rx.c
+++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
@@ -216,7 +216,7 @@ static int hfi1_netdev_rxq_init(struct hfi1_netdev_rx *rx)
* right now.
*/
set_bit(NAPI_STATE_NO_BUSY_POLL, &rxq->napi.state);
- netif_napi_add_weight(dev, &rxq->napi, hfi1_netdev_rx_napi, 64);
+ netif_napi_add(dev, &rxq->napi, hfi1_netdev_rx_napi);
rc = msix_netdev_request_rcd_irq(rxq->rcd);
if (rc)
goto bail_context_irq_failure;
--
2.15.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-01 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221129102500.616923-1-yang.yang29@zte.com.cn>
2022-11-30 8:40 ` [PATCH] IB/hfi1: switch to netif_napi_add() Leon Romanovsky
2022-11-30 9:44 yang.yang29
2022-12-01 9:10 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox