From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD46C47088 for ; Wed, 30 Nov 2022 10:08:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235539AbiK3KIY (ORCPT ); Wed, 30 Nov 2022 05:08:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234125AbiK3KIU (ORCPT ); Wed, 30 Nov 2022 05:08:20 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B463B248EB; Wed, 30 Nov 2022 02:08:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9BF5261AA2; Wed, 30 Nov 2022 10:08:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7617C433D7; Wed, 30 Nov 2022 10:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669802896; bh=9FvSvVLzySD8LbTfnoYpcK38CCZwnNYjsIckhInqktQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P0Yd5YZnMurOBSMnc+1boBGbX7+HW/x6DAtfPeXD3vOX+NZu9c/rTJbwa3nYtQfC1 5jh51yyT0/rdJ4UyhXfKtJHzmPV9i89AaDWJnydAV4vGaKLbcY0Y5LlPeXTqt9cqvP jFQownQSEWgOAUhX3swf4M67FWa8XssUy2yhee7Z2hpva2KCXq/6vWJSqS59m1nf3W Dze7SR7/FcFULDdvElVuJkbbbgDokuz4ek9aJFqaI2NpZ/nXNu7gNbWqdh2W2b+6AS 2nDwZOiWdgh8LV5V5V48cKLdEvX2/0sglK4kNObcAoltdrMboWzfzMN0uXeG2yndoH POpULBl8lpocA== Date: Wed, 30 Nov 2022 10:08:07 +0000 From: Lee Jones To: Alexandre Mergnat Cc: Mark Brown , Liam Girdwood , Alexandre Belloni , Krzysztof Kozlowski , Alessandro Zummo , Matthias Brugger , Rob Herring , Fabien Parent , Tianping Fang , Flora Fu , Chen Zhong , Sean Wang , Pavel Machek , Dmitry Torokhov , linux-mediatek@lists.infradead.org, AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, Rob Herring , Mattijs Korpershoek , linux-rtc@vger.kernel.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Fabien Parent , linux-leds@vger.kernel.org Subject: Re: [PATCH v7 4/8] dt-bindings: mfd: mediatek: Add bindings for MT6357 PMIC Message-ID: References: <20221005-mt6357-support-v7-0-477e60126749@baylibre.com> <20221005-mt6357-support-v7-4-477e60126749@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221005-mt6357-support-v7-4-477e60126749@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Nov 2022, Alexandre Mergnat wrote: > Currently, almost all MT63XX PMIC are documented mfd/mt6397.txt. > Unfortunately, the PMICs haven't always similar HW sub-features. > To have a better human readable schema, I chose to make one PMIC schema > to match the exact HW capabilities instead of convert mt6397.txt to > mediatek,mt63xx.yaml and put a bunch of properties behind > "if contain ... then ..." > > - add interrupt property > - change property refs to match with new yaml documentation > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Alexandre Mergnat Acked-by: Lee Jones > --- > .../devicetree/bindings/mfd/mediatek,mt6357.yaml | 111 +++++++++++++++++++++ > 1 file changed, 111 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml > new file mode 100644 > index 000000000000..837a77013d57 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml > @@ -0,0 +1,111 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/mediatek,mt6357.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT6357 PMIC > + > +maintainers: > + - Flora Fu > + - Alexandre Mergnat > + > +description: | > + MT6357 is a power management system chip containing 5 buck > + converters and 29 LDOs. Supported features are audio codec, > + USB battery charging, fuel gauge, RTC > + > + This is a multifunction device with the following sub modules: > + - Regulator > + - RTC > + - Keys > + > + It is interfaced to host controller using SPI interface by a proprietary hardware > + called PMIC wrapper or pwrap. This MFD is a child device of pwrap. > + See the following for pwrap node definitions: > + Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > + > +properties: > + compatible: > + const: mediatek,mt6357 > + > + interrupts: > + maxItems: 1 > + > + interrupt-controller: true > + > + "#interrupt-cells": > + const: 2 > + > + regulators: > + type: object > + $ref: /schemas/regulator/mediatek,mt6357-regulator.yaml > + description: > + List of MT6357 BUCKs and LDOs regulators. > + > + rtc: > + type: object > + $ref: /schemas/rtc/rtc.yaml# > + description: > + MT6357 Real Time Clock. > + properties: > + compatible: > + const: mediatek,mt6357-rtc > + start-year: true > + required: > + - compatible > + > + keys: > + type: object > + $ref: /schemas/input/mediatek,pmic-keys.yaml > + description: > + MT6357 power and home keys. > + > +required: > + - compatible > + - regulators > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + pwrap { > + pmic { > + compatible = "mediatek,mt6357"; > + > + interrupt-parent = <&pio>; > + interrupts = <145 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-controller; > + #interrupt-cells = <2>; > + > + regulators { > + mt6357_vproc_reg: buck-vproc { > + regulator-name = "vproc"; > + regulator-min-microvolt = <518750>; > + regulator-max-microvolt = <1312500>; > + regulator-ramp-delay = <6250>; > + regulator-enable-ramp-delay = <220>; > + regulator-always-on; > + }; > + > + // ... > + > + mt6357_vusb33_reg: ldo-vusb33 { > + regulator-name = "vusb33"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3100000>; > + regulator-enable-ramp-delay = <264>; > + }; > + }; > + > + rtc { > + compatible = "mediatek,mt6357-rtc"; > + }; > + > + keys { > + compatible = "mediatek,mt6357-keys"; > + }; > + }; > + }; > -- Lee Jones [李琼斯]