Re: [PATCH] dt-bindings: leds: Mark label property as deprecated

Pavel Machek
2022-11-30T19:27:01Z

[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]

On Wed 2022-11-30 13:19:05, Rob Herring wrote:
> On Fri, Nov 25, 2022 at 10:26:30PM +0100, Marek Vasut wrote:
> > On 11/22/22 13:23, Pavel Machek wrote:
> > > Hi!
> >
> > Hi,
> >
> > > > Mark the label property as deprecated as it is mentioned
> > > > in the description.
> > >
> > > Lets do it the other way around. Functions (etc) don't really provide
> > > good enough description of LED, and label is still needed.
> >
> > Can you please provide a clear explanation which property or approach is the
> > correct one for new DTs ?
> >
> > So far, the documentation states that "label" is deprecated, and users
> > should replace it with "function" and "color".
>
> 'function' is what activity/operation the LED is associated with. It is
> a fixed set of strings which s/w may use. It is a replacement for
> 'linux,default-trigger'.
>
> 'label' is what is printed next to the LED for a human to read. 'label'
> can be anything and the OS shouldn't care what it is.

Unfortunately, no.

We use label as a path in /sys/class/leds. And it looks like integer
"function" is not really adequate for describing what LED does. There
are too many LEDs and not enough integers, and it is common to have
same function ("activity") on multiple devices ("wifi", "mmc", "eth").

Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]