Re: [PATCH linux-next] dm: remove redundant sz variable

Mike Snitzer
2022-11-30T16:26:52Z

On Wed, Nov 30 2022 at 2:35P -0500,
zhang.songyi@zte.com.cn <zhang.songyi@zte.com.cn> wrote:

> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> Return value from hst_status() directly instead of taking
> this in another redundant variable.
>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> drivers/md/dm-ps-historical-service-time.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/dm-ps-historical-service-time.c b/drivers/md/dm-ps-historical-service-time.c
> index 1d82c95d323d..6c8e83ad2662 100644
> --- a/drivers/md/dm-ps-historical-service-time.c
> +++ b/drivers/md/dm-ps-historical-service-time.c
> @@ -237,7 +237,6 @@ static void hst_destroy(struct path_selector *ps)
> static int hst_status(struct path_selector *ps, struct dm_path *path,
> status_type_t type, char *result, unsigned int maxlen)
> {
> - unsigned int sz = 0;
> struct path_info *pi;
>
> if (!path) {
> @@ -261,7 +260,7 @@ static int hst_status(struct path_selector *ps, struct dm_path *path,
> }
> }
>
> - return sz;
> + return 0;
> }
>
> static int hst_add_path(struct path_selector *ps, struct dm_path *path,
> --
> 2.15.2
>

NACK

This sz variable is needed! (see DMEMIT)