From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98E7FC433FE for ; Wed, 30 Nov 2022 17:12:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbiK3RMj (ORCPT ); Wed, 30 Nov 2022 12:12:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231366AbiK3RMN (ORCPT ); Wed, 30 Nov 2022 12:12:13 -0500 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 799901EAE1 for ; Wed, 30 Nov 2022 09:07:47 -0800 (PST) Received: by mail-il1-x129.google.com with SMTP id g7so8406790ile.0 for ; Wed, 30 Nov 2022 09:07:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hwbeRXDCPnkzZaLAZJzPCmUQXCGZT3CgoSXNyHRIbL4=; b=UTV414O5U/PBfbN3sot40dFRdr29nsiDpH7mW9CHhEHTz8HwPQZW0ntrlp03S2Z5Qd 1lk+QJLhVEOQ7huOtOn8tc8jPC7n4Lakg01Cums/GaXHAJMooFd0fElMdwoRORoqpE+y VkP609mtJ+dEoFK7lXPFDJ1qYJam84wIP5Z3k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hwbeRXDCPnkzZaLAZJzPCmUQXCGZT3CgoSXNyHRIbL4=; b=t6pYYvhwmZ02lZFJsmdsqZUWHPpxOozwX+3aLO0S62IxBwOQicVthyY25n/3aN/fi3 QVvdDpH5MRnteLWc9eo4BUQ7HgUm1OQf/1DW5xjtFj3BgalUHmpxBrOeF1kRTuc4r+Bv nhPXRsaASjfoitgoOvtxeB5vGayxhySxUmKtfSYOSvou30qpu+A/kYzkU+RARcBJXO4m 8hDOfC/fqCPArtTio8bTwviLuRaddLJYS+EoLrMdqrNabxA1733e/DCtvqzk5b1ufd74 ZRYz0FA9LcHymOxFSBJUa0plJh3Ky+fXyrS9WgDuSLp8feGlCQYIpnoh7F9Fa1Jml3vB mLfg== X-Gm-Message-State: ANoB5pnyHdz80Z+B0F8Y1OfAsiuzGKkkd7FVAVExaSo0fKHs4TPluGIT zZs8a81qpybK+WQJg2UjqD6u1A== X-Google-Smtp-Source: AA0mqf7dRZ5ikRklhhLf4zCW66fwPUUtbqqE8HBiPfnHONAIRVgwN8feEkWTFgnbGzVdaW1H68FZGg== X-Received: by 2002:a92:dd82:0:b0:2f6:52ad:27e2 with SMTP id g2-20020a92dd82000000b002f652ad27e2mr19252287iln.285.1669828066772; Wed, 30 Nov 2022 09:07:46 -0800 (PST) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id j193-20020a0263ca000000b003717c1df569sm736403jac.165.2022.11.30.09.07.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 09:07:46 -0800 (PST) Date: Wed, 30 Nov 2022 17:07:46 +0000 From: Matthias Kaehlcke To: Srinivasa Rao Mandadapu Cc: agross@kernel.org, andersson@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@quicinc.com, perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, judyhsiao@chromium.org, devicetree@vger.kernel.org Subject: Re: [PATCH] ASoC: qcom: lpass-sc7180: Add maybe_unused tag for system PM ops Message-ID: References: <1669726428-3140-1-git-send-email-quic_srivasam@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1669726428-3140-1-git-send-email-quic_srivasam@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote: > Add __maybe_unused tag for system PM ops suspend and resume. > This is required to fix allmodconfig compilation issue. > Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops") This is incorrect, it should be '2d68148f8f85 ("ASoC: qcom: lpass-sc7180: Add system suspend/resume PM ops")'. I see you fixed that in v2, but this patch has already been applied ... Srinivasa, it seems a similar patch is needed for commit c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops"). For that you could use SYSTEM_SLEEP_PM_OPS() instead of the maybe_unused tags as suggested by Nathan. Mark, I appreciate you being responsive and picking patches quickly, it might help though to leave 'external' reviewers at least some time to provide their feedback :)