From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3F20C4321E for ; Thu, 1 Dec 2022 09:24:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229967AbiLAJYK (ORCPT ); Thu, 1 Dec 2022 04:24:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbiLAJXr (ORCPT ); Thu, 1 Dec 2022 04:23:47 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFAC111A0C; Thu, 1 Dec 2022 01:22:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1E16CB81E7C; Thu, 1 Dec 2022 09:22:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53FC4C433D7; Thu, 1 Dec 2022 09:22:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669886559; bh=EbQEoSBkP4rq4nn7K1JqrZiC11qeUR4OKMOBmxo+YsU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hBnQ+JpnHiKrLR4z5/n48+eyUysKLHUFm7o0Z+Axi7KExPgLunVQtxraqEUfqJMXi iv0ygBuculcBlEAvw2RZLNVX0kDcwYcoBtEArun/pdfGOxiXwpmvz2m2vuWOr0XLSo /OXiCAxjIIGfsTXkoc52W8jnJ8vftiPGlIb8FLKrel9K2C0qp4/HVYk/1kNgiWSg7w bXl+fzrKnVbYl8rKHoZ9BHgwax6TKREJzTQ9kWVMRgnKMkXBHrVrwzODKL3QoRUBWk yDfuHKtBidWAxCRPfUISLLNQOcSDpVVj4w4fRSs/ivWW6RWmWpRRNCkyQQEoxuk11M J1OeSaqpS/JVw== Date: Thu, 1 Dec 2022 11:22:35 +0200 From: Leon Romanovsky To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Jason Gunthorpe , Dennis Dalessandro , linux-rdma@vger.kernel.org, Jeff Dike , Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org Subject: Re: [PATCH 2/2] IB/rdmavt: don't use rdmavt for UML Message-ID: References: <20221130200958.25305-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221130200958.25305-1-rdunlap@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30, 2022 at 12:09:58PM -0800, Randy Dunlap wrote: > When building rdmavt for ARCH=um, qp.c has a build error on a reference > to the x86-specific cpuinfo field 'x86_cache_size'. > > Fix the build errors by making this driver depend on !UML. > > Prevents these build errors: > > ../drivers/infiniband/sw/rdmavt/qp.c: In function ‘rvt_wss_llc_size’: > ../drivers/infiniband/sw/rdmavt/qp.c:88:29: error: ‘struct cpuinfo_um’ has no member named ‘x86_cache_size’ > 88 | return boot_cpu_data.x86_cache_size; > ../drivers/infiniband/sw/rdmavt/qp.c: In function ‘cacheless_memcpy’: > ../drivers/infiniband/sw/rdmavt/qp.c:100:9: error: implicit declaration of function ‘__copy_user_nocache’; did you mean ‘copy_user_page’? [-Werror=implicit-function-declaration] > 100 | __copy_user_nocache(dst, (void __user *)src, n, 0); > ../drivers/infiniband/sw/rdmavt/qp.c: In function ‘rvt_wss_llc_size’: > ../drivers/infiniband/sw/rdmavt/qp.c:89:1: error: control reaches end of non-void function [-Werror=return-type] > 89 | } > > Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver") > Signed-off-by: Randy Dunlap > Cc: Jason Gunthorpe > Cc: Leon Romanovsky > Cc: Dennis Dalessandro > Cc: linux-rdma@vger.kernel.org > Cc: Jeff Dike > Cc: Richard Weinberger > Cc: Anton Ivanov > Cc: Johannes Berg > Cc: linux-um@lists.infradead.org > --- > v2: rebase & resend > > drivers/infiniband/sw/rdmavt/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -- a/drivers/infiniband/sw/rdmavt/Kconfig b/drivers/infiniband/sw/rdmavt/Kconfig > --- a/drivers/infiniband/sw/rdmavt/Kconfig > +++ b/drivers/infiniband/sw/rdmavt/Kconfig > @@ -2,7 +2,7 @@ > config INFINIBAND_RDMAVT > tristate "RDMA verbs transport library" > depends on INFINIBAND_VIRT_DMA > - depends on X86_64 > + depends on X86_64 && !UML Same comment as for patch #1. > depends on PCI > help > This is a common software verbs provider for RDMA networks.