From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
macro@orcam.me.uk, jay.dolan@accesio.com, cang1@live.co.uk,
u.kleine-koenig@pengutronix.de, wander@redhat.com,
etremblay@distech-controls.com, jk@ozlabs.org,
biju.das.jz@bp.renesas.com, geert+renesas@glider.be,
phil.edworthy@renesas.com, Lukas Wunner <lukas@wunner.de>,
UNGLinuxDriver@microchip.com, colin.i.king@gmail.com,
Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>
Subject: Re: [PATCH v6 tty-next 1/4] serial: 8250_pci: Add serial8250_pci_setup_port definition in 8250_pcilib.c
Date: Thu, 1 Dec 2022 14:11:55 +0200 [thread overview]
Message-ID: <Y4iaC7rRkBhyOIsI@smile.fi.intel.com> (raw)
In-Reply-To: <1189f5af-aaac-f4c8-b928-cda183e7f90@linux.intel.com>
On Thu, Dec 01, 2022 at 11:06:53AM +0200, Ilpo Järvinen wrote:
> On Thu, 1 Dec 2022, Kumaravel Thiagarajan wrote:
...
> > +/*
> > + * 8250 PCI library header file.
> > + *
> > + * Copyright (C) 2001 Russell King, All Rights Reserved.
> > + */
>
> You shouldn't depend on .c file having things included for you. So
> please add these:
> #include "8250.h"
TBH I don't see how this is used here, but types.h for sure is missing.
> struct pci_dev;
+ blank line
struct uart_8250_port;
> Other than that,
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
> > +int serial8250_pci_setup_port(struct pci_dev *dev, struct uart_8250_port *port, u8 bar,
> > + unsigned int offset, int regshift);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-12-01 12:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 4:51 [PATCH v6 tty-next 0/4] serial: 8250_pci1xxxx: Add driver for the pci1xxxx's quad-uart function Kumaravel Thiagarajan
2022-12-01 4:51 ` [PATCH v6 tty-next 1/4] serial: 8250_pci: Add serial8250_pci_setup_port definition in 8250_pcilib.c Kumaravel Thiagarajan
2022-12-01 9:06 ` Ilpo Järvinen
2022-12-01 12:11 ` Andy Shevchenko [this message]
2022-12-06 19:09 ` Tharunkumar.Pasumarthi
2022-12-06 22:18 ` Andy Shevchenko
2022-12-01 12:10 ` Andy Shevchenko
2022-12-01 4:51 ` [PATCH v6 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for quad-uart support Kumaravel Thiagarajan
2022-12-01 9:39 ` Ilpo Järvinen
2022-12-04 10:39 ` Tharunkumar.Pasumarthi
2022-12-01 4:51 ` [PATCH v6 tty-next 3/4] serial: 8250_pci1xxxx: Add RS485 support to quad-uart driver Kumaravel Thiagarajan
2022-12-01 9:47 ` Ilpo Järvinen
2022-12-07 11:51 ` Kumaravel.Thiagarajan
2022-12-01 4:51 ` [PATCH v6 tty-next 4/4] serial: 8250_pci1xxxx: Add power management functions " Kumaravel Thiagarajan
2022-12-01 12:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4iaC7rRkBhyOIsI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=cang1@live.co.uk \
--cc=colin.i.king@gmail.com \
--cc=etremblay@distech-controls.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jay.dolan@accesio.com \
--cc=jirislaby@kernel.org \
--cc=jk@ozlabs.org \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=phil.edworthy@renesas.com \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox