From: Simon Horman <simon.horman@corigine.com>
To: wangchuanlei <wangchuanlei@inspur.com>
Cc: kuba@kernel.org, dev@openvswitch.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, edumazet@google.com,
alexandr.lobakin@intel.com, pabeni@redhat.com,
davem@davemloft.net
Subject: Re: [ovs-dev] [PATCH] [PATCH v6 net-next] net: openvswitch: Add support to count upcall packets
Date: Thu, 1 Dec 2022 13:46:48 +0100 [thread overview]
Message-ID: <Y4iiOBzus5v5aOIP@corigine.com> (raw)
In-Reply-To: <20221201084601.3598586-1-wangchuanlei@inspur.com>
Hi,
On Thu, Dec 01, 2022 at 03:46:01AM -0500, wangchuanlei wrote:
> Hi, Jakub,
>
> Thank you for review, the comments below is a little confusing, can you
> give a explanation?
>
> Best regards!
> wangchuanlei
>
> --------------------------------------------------------
> On Wed, 30 Nov 2022 04:15:59 -0500 wangchuanlei wrote:
> > +/**
> > + * ovs_vport_get_upcall_stats - retrieve upcall stats
> > + *
> > + * @vport: vport from which to retrieve the stats
> > + * @ovs_vport_upcall_stats: location to store stats
>
> s/ovs_vport_upcall_//
I believe Jakub is asking for "ovs_vport_upcall_" to be removed.
Or, in other words, to refer to the parameter as "stats",
(which matches the name in the function signature below).
>
> > + *
> > + * Retrieves upcall stats for the given device.
> > + *
> > + * Must be called with ovs_mutex or rcu_read_lock.
> > + */
> > +void ovs_vport_get_upcall_stats(struct vport *vport, struct ovs_vport_upcall_stats *stats)
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
prev parent reply other threads:[~2022-12-01 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 8:46 [PATCH] [PATCH v6 net-next] net: openvswitch: Add support to count upcall packets wangchuanlei
2022-12-01 12:46 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4iiOBzus5v5aOIP@corigine.com \
--to=simon.horman@corigine.com \
--cc=alexandr.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangchuanlei@inspur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox