* Re: [PATCH] [PATCH v6 net-next] net: openvswitch: Add support to count upcall packets
@ 2022-12-01 8:46 wangchuanlei
2022-12-01 12:46 ` [ovs-dev] " Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: wangchuanlei @ 2022-12-01 8:46 UTC (permalink / raw)
To: kuba
Cc: echaudro, alexandr.lobakin, pabeni, pshelar, davem, edumazet,
wangpeihui, netdev, dev, linux-kernel
Hi, Jakub,
Thank you for review, the comments below is a little confusing, can you
give a explanation?
Best regards!
wangchuanlei
--------------------------------------------------------
On Wed, 30 Nov 2022 04:15:59 -0500 wangchuanlei wrote:
> +/**
> + * ovs_vport_get_upcall_stats - retrieve upcall stats
> + *
> + * @vport: vport from which to retrieve the stats
> + * @ovs_vport_upcall_stats: location to store stats
s/ovs_vport_upcall_//
> + *
> + * Retrieves upcall stats for the given device.
> + *
> + * Must be called with ovs_mutex or rcu_read_lock.
> + */
> +void ovs_vport_get_upcall_stats(struct vport *vport, struct ovs_vport_upcall_stats *stats)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [ovs-dev] [PATCH] [PATCH v6 net-next] net: openvswitch: Add support to count upcall packets
2022-12-01 8:46 [PATCH] [PATCH v6 net-next] net: openvswitch: Add support to count upcall packets wangchuanlei
@ 2022-12-01 12:46 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2022-12-01 12:46 UTC (permalink / raw)
To: wangchuanlei
Cc: kuba, dev, netdev, linux-kernel, edumazet, alexandr.lobakin,
pabeni, davem
Hi,
On Thu, Dec 01, 2022 at 03:46:01AM -0500, wangchuanlei wrote:
> Hi, Jakub,
>
> Thank you for review, the comments below is a little confusing, can you
> give a explanation?
>
> Best regards!
> wangchuanlei
>
> --------------------------------------------------------
> On Wed, 30 Nov 2022 04:15:59 -0500 wangchuanlei wrote:
> > +/**
> > + * ovs_vport_get_upcall_stats - retrieve upcall stats
> > + *
> > + * @vport: vport from which to retrieve the stats
> > + * @ovs_vport_upcall_stats: location to store stats
>
> s/ovs_vport_upcall_//
I believe Jakub is asking for "ovs_vport_upcall_" to be removed.
Or, in other words, to refer to the parameter as "stats",
(which matches the name in the function signature below).
>
> > + *
> > + * Retrieves upcall stats for the given device.
> > + *
> > + * Must be called with ovs_mutex or rcu_read_lock.
> > + */
> > +void ovs_vport_get_upcall_stats(struct vport *vport, struct ovs_vport_upcall_stats *stats)
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-01 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-01 8:46 [PATCH] [PATCH v6 net-next] net: openvswitch: Add support to count upcall packets wangchuanlei
2022-12-01 12:46 ` [ovs-dev] " Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox