public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Masney <bmasney@redhat.com>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, cth451@gmail.com
Subject: Re: [EXT] Re: [PATCH] net: atlantic: fix check for invalid ethernet addresses
Date: Thu, 1 Dec 2022 08:55:01 -0500	[thread overview]
Message-ID: <Y4iyNRhkFmG/Avco@x1> (raw)
In-Reply-To: <7ed83813-0df4-b6ac-f1d2-a28d8011b1aa@marvell.com>

On Thu, Dec 01, 2022 at 09:07:49AM +0100, Igor Russkikh wrote:
> 
> >> That won't work for this board since that function only checks that the
> >> MAC "is not 00:00:00:00:00:00, is not a multicast address, and is not
> >> FF:FF:FF:FF:FF:FF." The MAC address that we get on all of our boards is
> >> 00:17:b6:00:00:00.
> > 
> > Which is a valid MAC address. So i don't see why the kernel should
> > reject it and use a random one.
> > 
> > Maybe you should talk to Marvell about how you can program the
> > e-fuses. You can then use MAC addresses from A8-97-DC etc.
> 
> Hi Brian,
> 
> I do completely agree with Andrew. Thats not a fix to be made in
> linux kernel.
> 
> The boards you get have zero efuse. You should work with Qualcomm on
> how to update mac addresses of your boards.

OK, I'll work to track down someone within Qualcomm that can help us
program the MAC address into the boards that we have. In the mean time,
we'll go with the systemd unit approach to set a MAC address.

Thank you all!

Brian


  reply	other threads:[~2022-12-01 13:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 17:42 [PATCH] net: atlantic: fix check for invalid ethernet addresses Brian Masney
2022-11-30 17:57 ` Brian Masney
2022-11-30 18:26   ` Tianhao Chai
2022-11-30 18:47     ` Brian Masney
2022-11-30 19:41 ` Andrew Lunn
2022-11-30 21:08   ` Brian Masney
2022-11-30 21:32     ` Andrew Lunn
2022-11-30 23:12       ` David Laight
2022-12-01  2:22         ` Andrew Lunn
2022-12-01  8:07       ` [EXT] " Igor Russkikh
2022-12-01 13:55         ` Brian Masney [this message]
2022-12-01 14:14         ` Andrew Lunn
2022-12-01 15:18           ` Igor Russkikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4iyNRhkFmG/Avco@x1 \
    --to=bmasney@redhat.com \
    --cc=andrew@lunn.ch \
    --cc=cth451@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=irusskikh@marvell.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox