Re: [PATCH 1/5] driver core: make struct class.dev_uevent() take a const *

Bart Van Assche
2022-11-25T23:51:22Z

On 11/23/22 04:25, Greg Kroah-Hartman wrote:
> diff --git a/include/linux/mISDNif.h b/include/linux/mISDNif.h
> index 7dd1f01ec4f9..7aab4a769736 100644
> --- a/include/linux/mISDNif.h
> +++ b/include/linux/mISDNif.h
> @@ -586,7 +586,7 @@ extern struct mISDNclock *mISDN_register_clock(char *, int, clockctl_func_t *,
> void *);
> extern void mISDN_unregister_clock(struct mISDNclock *);
>
> -static inline struct mISDNdevice *dev_to_mISDN(struct device *dev)
> +static inline struct mISDNdevice *dev_to_mISDN(const struct device *dev)
> {
> if (dev)
> return dev_get_drvdata(dev);

Why does the dev_to_mISDN() function drop constness? I haven't found an
explanation for this in the cover letter.

Thanks,

Bart.