Re: [PATCH v1 2/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string

yanhong wang
2022-12-08T01:42:36Z

On 2022/12/7 21:58, Emil Renner Berthing wrote:
> On Thu, 1 Dec 2022 at 10:05, Yanhong Wang <yanhong.wang@starfivetech.com> wrote:
>>
>> Add "snps,dwmac-5.20" compatible string for 5.20 version that can avoid
>> to define some platform data in the glue layer.
>>
>> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
>
> Hi Yanhong.
>
> Thanks for submitting this.
> But just as a reminder. Please don't change the author of the commits
> you cherry-picked from my tree.
>

I will recover the author is you in the next version.

> /Emil
>
>> ---
>> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> index 50f6b4a14be4..cc3b701af802 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> @@ -519,7 +519,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
>> if (of_device_is_compatible(np, "snps,dwmac-4.00") ||
>> of_device_is_compatible(np, "snps,dwmac-4.10a") ||
>> of_device_is_compatible(np, "snps,dwmac-4.20a") ||
>> - of_device_is_compatible(np, "snps,dwmac-5.10a")) {
>> + of_device_is_compatible(np, "snps,dwmac-5.10a") ||
>> + of_device_is_compatible(np, "snps,dwmac-5.20")) {
>> plat->has_gmac4 = 1;
>> plat->has_gmac = 0;
>> plat->pmt = 1;
>> --
>> 2.17.1
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv