* Re: [PATCH] nsfs: add compat ioctl handler
[not found] <20221214-nsfs-ioctl-compat-v1-0-b169796000b2@weissschuh.net>
@ 2022-12-18 21:25 ` Al Viro
0 siblings, 0 replies; only message in thread
From: Al Viro @ 2022-12-18 21:25 UTC (permalink / raw)
To: Thomas Weißschuh
Cc: Serge Hallyn, Andrey Vagin, Eric W. Biederman, linux-fsdevel,
linux-kernel, Karel Zak
On Sun, Dec 18, 2022 at 09:07:25PM +0000, Thomas Weißschuh wrote:
> As all parameters and return values of the ioctls have the same
> representation on both 32bit and 64bit we can reuse the normal ioctl
> handler for the compat handler.
>
> All nsfs ioctls return a plain "int" filedescriptor which is a signed
> 4-byte integer type on both 32bit and 64bit.
> The only parameter taken is by NS_GET_OWNER_UID and is a pointer to a
> "uid_t" which is a 4-byte unsigned integer type on both 32bit and 64bit.
>
> Fixes: 6786741dbf99 ("nsfs: add ioctl to get an owning user namespace for ns file descriptor")
> Reported-By: Karel Zak <kzak@redhat.com>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
NAK. This is broken on s390; use compat_ptr_ioctl instead.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-12-18 21:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221214-nsfs-ioctl-compat-v1-0-b169796000b2@weissschuh.net>
2022-12-18 21:25 ` [PATCH] nsfs: add compat ioctl handler Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox