Re: [PATCH v4 net-next 7/9] dt-bindings: net: add generic ethernet-switch

Rob Herring
2022-12-05T21:50:25Z

On Fri, Dec 02, 2022 at 12:45:57PM -0800, Colin Foster wrote:
> The dsa.yaml bindings had references that can apply to non-dsa switches. To
> prevent duplication of this information, keep the dsa-specific information
> inside dsa.yaml and move the remaining generic information to the newly
> created ethernet-switch.yaml.
>
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>
> v3 -> v4
> * Update ethernet-ports and ethernet-port nodes to match what the new
> dsa.yaml has. Namely:
> "unevaluatedProperties: false" instead of "additionalProperties: true"
> "additionalProperties: true" instead of "unevaluatedProperties: true"
> for ethernet-ports and ethernet-port, respectively.
> * Add Florian Reviewed tag
>
> v2 -> v3
> * Change ethernet-switch.yaml title from "Ethernet Switch Device
> Tree Bindings" to "Generic Ethernet Switch"
> * Rework ethernet-switch.yaml description
> * Add base defs structure for switches that don't have any additional
> properties.
> * Add "additionalProperties: true" under "^(ethernet-)?ports$" node
> * Correct port reference from /schemas/net/dsa/dsa-port.yaml# to
> ethernet-controller.yaml#
>
> v1 -> v2
> * No net change, but deletions from dsa.yaml included the changes for
> "addionalProperties: true" under ports and "unevaluatedProperties:
> true" under port.
>
> ---
> .../devicetree/bindings/net/dsa/dsa.yaml | 28 +-------
> .../bindings/net/ethernet-switch.yaml | 66 +++++++++++++++++++
> MAINTAINERS | 1 +
> 3 files changed, 69 insertions(+), 26 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/ethernet-switch.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> index 5081f4979f1b..843205ea722d 100644
> --- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> @@ -18,6 +18,8 @@ description:
>
> select: false
>
> +$ref: "/schemas/net/ethernet-switch.yaml#"

You can drop quotes here.

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

This is a nice clean-up.

Rob