From: Borislav Petkov <bp@alien8.de>
To: Baoquan He <bhe@redhat.com>
Cc: Eric DeVolder <eric.devolder@oracle.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, ebiederm@xmission.com,
dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de,
mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com,
nramas@linux.microsoft.com, thomas.lendacky@amd.com,
robh@kernel.org, efault@gmx.de, rppt@kernel.org,
david@redhat.com, sourabhjain@linux.ibm.com,
konrad.wilk@oracle.com, boris.ostrovsky@oracle.com
Subject: Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support
Date: Wed, 7 Dec 2022 16:56:11 +0100 [thread overview]
Message-ID: <Y5C3mzQLviL54IK6@zn.tnic> (raw)
In-Reply-To: <Y5Cb3KGDXijyBXfM@MiWiFi-R3L-srv>
On Wed, Dec 07, 2022 at 09:57:48PM +0800, Baoquan He wrote:
> I thought we usually need to introduce the kernel config option, then
> add code related to it, so that is a wrong idea.
It depends: sometimes it is prudent to add the code behind an ifdeffery
first but have it not being buildable so that you don't have to deal
with build breakages but rather concentrate on adding the facilities
first.
And you add the Kconfig item only in the end where everything is in
place and it should build properly then.
> It would be helpful to tell this somewhere in document.
Feel free. I mean, it is pretty obvious but if it helps, it wouldn't hurt.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-12-07 15:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 21:46 [PATCH v14 0/7] crash: Kernel handling of CPU and memory hot un/plug Eric DeVolder
2022-11-16 21:46 ` [PATCH v14 1/7] crash: move crash_prepare_elf64_headers() Eric DeVolder
2022-11-16 21:46 ` [PATCH v14 2/7] crash: prototype change for crash_prepare_elf64_headers() Eric DeVolder
2022-11-16 21:46 ` [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support Eric DeVolder
2022-11-25 3:26 ` Baoquan He
2022-11-28 15:46 ` Eric DeVolder
2022-11-29 0:43 ` Baoquan He
2022-12-07 10:00 ` Borislav Petkov
2022-12-07 12:36 ` Baoquan He
2022-12-07 12:42 ` Borislav Petkov
2022-12-07 13:57 ` Baoquan He
2022-12-07 15:56 ` Borislav Petkov [this message]
2022-12-08 4:03 ` Baoquan He
2022-12-07 10:15 ` Borislav Petkov
2022-12-08 19:04 ` Eric DeVolder
2022-11-16 21:46 ` [PATCH v14 4/7] kexec: exclude elfcorehdr from the segment digest Eric DeVolder
2022-11-16 21:46 ` [PATCH v14 5/7] kexec: exclude hot remove cpu from elfcorehdr notes Eric DeVolder
2022-11-16 21:46 ` [PATCH v14 6/7] crash: memory and cpu hotplug sysfs attributes Eric DeVolder
2022-11-16 21:46 ` [PATCH v14 7/7] x86/crash: add x86 crash hotplug support Eric DeVolder
2022-12-07 10:19 ` Borislav Petkov
2022-12-08 20:34 ` Eric DeVolder
2022-11-23 15:31 ` [PATCH v14 0/7] crash: Kernel handling of CPU and memory hot un/plug Sourabh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5C3mzQLviL54IK6@zn.tnic \
--to=bp@alien8.de \
--cc=bhe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=efault@gmx.de \
--cc=eric.devolder@oracle.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nramas@linux.microsoft.com \
--cc=robh@kernel.org \
--cc=rppt@kernel.org \
--cc=sourabhjain@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox