From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A62CEC4708E for ; Wed, 7 Dec 2022 15:56:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229760AbiLGP4S (ORCPT ); Wed, 7 Dec 2022 10:56:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbiLGP4O (ORCPT ); Wed, 7 Dec 2022 10:56:14 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4750262CA for ; Wed, 7 Dec 2022 07:56:13 -0800 (PST) Received: from zn.tnic (p200300ea9733e711329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e711:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D1E991EC0513; Wed, 7 Dec 2022 16:56:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1670428571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=JedNHJvTEEw3ngTfwq+GhcMA8oL9D/gBR+soBVALxbA=; b=GKj+moEuIiUJgoIjdqmbjvmbgbpbKy4esY6NqqiZ0Y+hVPmlLWCZdkwD9ik5rVUU7jkoCv jy4xPiZ/9Gj+76MXrkbgx7kXEmGXewJacn2aSUe7zH3ZiRgiPHFLdz0wpkl+lkCeR/fpfq dFF4+cq2L5WT0/xLo5JmQPUQsYCxkFY= Date: Wed, 7 Dec 2022 16:56:11 +0100 From: Borislav Petkov To: Baoquan He Cc: Eric DeVolder , linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com, sourabhjain@linux.ibm.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support Message-ID: References: <20221116214643.6384-1-eric.devolder@oracle.com> <20221116214643.6384-4-eric.devolder@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 07, 2022 at 09:57:48PM +0800, Baoquan He wrote: > I thought we usually need to introduce the kernel config option, then > add code related to it, so that is a wrong idea. It depends: sometimes it is prudent to add the code behind an ifdeffery first but have it not being buildable so that you don't have to deal with build breakages but rather concentrate on adding the facilities first. And you add the Kconfig item only in the end where everything is in place and it should build properly then. > It would be helpful to tell this somewhere in document. Feel free. I mean, it is pretty obvious but if it helps, it wouldn't hurt. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette