From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD0BC352A1 for ; Wed, 7 Dec 2022 12:37:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229718AbiLGMhc (ORCPT ); Wed, 7 Dec 2022 07:37:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbiLGMha (ORCPT ); Wed, 7 Dec 2022 07:37:30 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04D2A532F1 for ; Wed, 7 Dec 2022 04:36:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670416588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9atWu9JU4Cx+ETdJlBYNzYOikPveUu+xlZLV8W2MIpw=; b=bi8xuoGAoBBorLpbBdbO3inGXM9si7s/wwi9wlFczWv6a73aTrzYffi+Nz6Yb2Mb0GODuc 7qtPwJKHUsq/vQyZqY2OTCuHNUoe37LGtFZWi/E0cWdczWcvvZ9yy7AhfB6SKCIcvECMNp QZLI5t6EDpt2gVh0l5XNGxfJc8KroT8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647-KQv1VQ-TPnmsF6_VZrQsNw-1; Wed, 07 Dec 2022 07:36:24 -0500 X-MC-Unique: KQv1VQ-TPnmsF6_VZrQsNw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5D86A380450D; Wed, 7 Dec 2022 12:36:23 +0000 (UTC) Received: from localhost (ovpn-13-181.pek2.redhat.com [10.72.13.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 378A620FD3AA; Wed, 7 Dec 2022 12:36:22 +0000 (UTC) Date: Wed, 7 Dec 2022 20:36:13 +0800 From: Baoquan He To: Borislav Petkov Cc: Eric DeVolder , linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com, sourabhjain@linux.ibm.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support Message-ID: References: <20221116214643.6384-1-eric.devolder@oracle.com> <20221116214643.6384-4-eric.devolder@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/22 at 11:00am, Borislav Petkov wrote: > On Fri, Nov 25, 2022 at 11:26:53AM +0800, Baoquan He wrote: > > This kernel config CRASH_HOTPLUG is added in patch 7, but we have used > > it in the previous patch, not sure if this is acceptable. > > Why would it not be acceptable? Below is my last reply to Eric about my thinking on this. That would be great if it's a normal situation when adding Kconfig item, I am happy to learn this if it's confirmed normal. ===== Hmm, since it's bisect-able, seems doesn't break rule. I could be too sensitive. Do we have a precendent like this, to strengthen our confidence? If no concern from other people, it's also fine to me. ===== Thanks Baoquan