From: Chen Yu <yu.c.chen@intel.com>
To: Josh Don <joshdon@google.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Joel Fernandes <joel@joelfernandes.org>,
Honglei Wang <wanghonglei@didichuxing.com>,
"Peter Zijlstra" <peterz@infradead.org>,
Tim Chen <tim.c.chen@intel.com>,
Mel Gorman <mgorman@techsingularity.net>,
Juri Lelli <juri.lelli@redhat.com>,
"Rik van Riel" <riel@surriel.com>, Aaron Lu <aaron.lu@intel.com>,
Abel Wu <wuyun.abel@bytedance.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
"Yicong Yang" <yangyicong@hisilicon.com>,
"Gautham R . Shenoy" <gautham.shenoy@amd.com>,
Ingo Molnar <mingo@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Hillf Danton <hdanton@sina.com>, Len Brown <len.brown@intel.com>,
Chen Yu <yu.chen.surf@gmail.com>,
"Tianchen Ding" <dtcccc@linux.alibaba.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] sched/fair: Introduce short duration task check
Date: Wed, 7 Dec 2022 22:24:55 +0800 [thread overview]
Message-ID: <Y5CiN010QAwklahh@chenyu5-mobl1> (raw)
In-Reply-To: <CABk29Nuc+VVOpAwFsbBo+OppayszebT29Hadc8qK-xeyZpY6NQ@mail.gmail.com>
Hi Josh,
On 2022-12-06 at 18:23:47 -0800, Josh Don wrote:
> > We don't want to add more dedicated knobs. So using
> > sysctl_sched_min_granularity as you are doing in this patch looks ok
>
> If not a knob, then maybe at least a smaller hardcoded value? Several
> milliseconds seems like too long for this optimization; the
> opportunity cost of not doing the idle search likely doesn't make
> sense if the waker is going to be active for several additional
> milliseconds. I would have guessed something on the order of 100us.
>
> Chen, what is the run duration of tasks in your ping pong example?
OK, I'll measure the duration of all the tests and summarize the data later.
thanks,
Chenyu
next prev parent reply other threads:[~2022-12-07 14:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 8:43 [PATCH v3 0/2] sched/fair: Choose the CPU where short task is running during wake up Chen Yu
2022-12-01 8:44 ` [PATCH v3 1/2] sched/fair: Introduce short duration task check Chen Yu
2022-12-02 7:44 ` Honglei Wang
2022-12-03 7:49 ` Chen Yu
2022-12-03 15:35 ` Joel Fernandes
2022-12-05 8:38 ` Chen Yu
2022-12-05 9:59 ` Vincent Guittot
2022-12-05 14:38 ` Chen Yu
2022-12-07 2:23 ` Josh Don
2022-12-07 14:24 ` Chen Yu [this message]
2022-12-12 11:22 ` Yicong Yang
2022-12-12 14:33 ` Chen Yu
2022-12-12 18:17 ` Josh Don
2022-12-13 5:46 ` Chen Yu
2022-12-13 10:06 ` Honglei Wang
2022-12-13 12:24 ` Chen Yu
2022-12-01 8:44 ` [PATCH v3 2/2] sched/fair: Choose the CPU where short task is running during wake up Chen Yu
2022-12-05 2:36 ` Tianchen Ding
2022-12-05 8:40 ` Chen Yu
2022-12-06 13:02 ` Yicong Yang
2022-12-07 3:54 ` Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5CiN010QAwklahh@chenyu5-mobl1 \
--to=yu.c.chen@intel.com \
--cc=aaron.lu@intel.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=dtcccc@linux.alibaba.com \
--cc=gautham.shenoy@amd.com \
--cc=hdanton@sina.com \
--cc=joel@joelfernandes.org \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wanghonglei@didichuxing.com \
--cc=wuyun.abel@bytedance.com \
--cc=yangyicong@hisilicon.com \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox