Re: [PATCH] dt-bindings: Add missing 'unevaluatedProperties' to regulator nodes

Sebastian Reichel
2022-12-07T17:00:21Z

[-- Attachment #1: Type: text/plain, Size: 2016 bytes --]

Hi,

On Tue, Dec 06, 2022 at 03:15:55PM -0600, Rob Herring wrote:
> Several regulator schemas are missing 'unevaluatedProperties' constraint
> which means any extra properties are allowed. Upon adding the
> constraint, there's numerous warnings from using the deprecated
> 'regulator-compatible' property. Remove the usage as examples shouldn't
> be using long since deprecated properties.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> I'd suggest that Mark take this if that's okay with Lee. Or I can take
> it.
>
> Documentation/devicetree/bindings/mfd/max77650.yaml | 2 --
> .../devicetree/bindings/mfd/mediatek,mt6360.yaml | 9 ---------
> .../bindings/power/supply/mt6360_charger.yaml | 2 +-
> .../bindings/regulator/max77650-regulator.yaml | 1 +
> .../devicetree/bindings/regulator/max8660.yaml | 6 +-----
> .../bindings/regulator/mt6360-regulator.yaml | 12 +++---------
> 6 files changed, 6 insertions(+), 26 deletions(-)
>
> [...]
>
> diff --git a/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml b/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml
> index b89b15a5bfa4..4c74cc78729e 100644
> --- a/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml
> @@ -26,6 +26,7 @@ properties:
> type: object
> description: OTG boost regulator.
> $ref: /schemas/regulator/regulator.yaml#
> + unevaluatedProperties: false
>
> required:
> - compatible
> @@ -39,7 +40,6 @@ examples:
> richtek,vinovp-microvolt = <14500000>;
>
> otg_vbus_regulator: usb-otg-vbus-regulator {
> - regulator-compatible = "usb-otg-vbus";
> regulator-name = "usb-otg-vbus";
> regulator-min-microvolt = <4425000>;
> regulator-max-microvolt = <5825000>;

Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>

> [...]

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]