From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Satya Priya <quic_c_skakit@quicinc.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] leds: qcom,pm8058-led: Convert to DT schema
Date: Thu, 8 Dec 2022 10:57:45 +0000 [thread overview]
Message-ID: <Y5HDKfC8Q1F7FXcI@google.com> (raw)
In-Reply-To: <947e47d3-4235-8f16-d3ef-c3ddd7d51acf@linaro.org>
On Thu, 08 Dec 2022, Krzysztof Kozlowski wrote:
> On 08/12/2022 11:09, Lee Jones wrote:
> > On Wed, 07 Dec 2022, Pavel Machek wrote:
> >
> >> On Thu 2022-12-01 18:08:58, Rob Herring wrote:
> >>> On Thu, Dec 01, 2022 at 02:15:05PM +0100, Krzysztof Kozlowski wrote:
> >>>> Convert the Qualcomm PM8058 PMIC LED bindings to DT schema.
> >>>>
> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>>> ---
> >>>> .../devicetree/bindings/leds/leds-pm8058.txt | 67 -------------------
> >>>> .../bindings/leds/qcom,pm8058-led.yaml | 57 ++++++++++++++++
> >>>> .../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 4 ++
> >>>> 3 files changed, 61 insertions(+), 67 deletions(-)
> >>>> delete mode 100644 Documentation/devicetree/bindings/leds/leds-pm8058.txt
> >>>> create mode 100644 Documentation/devicetree/bindings/leds/qcom,pm8058-led.yaml
> >>>
> >>> Reviewed-by: Rob Herring <robh@kernel.org>
> >>>
> >>> Or should I apply it?
> >>
> >> Thanks for ACK, let me take it, I guess.
> >
> > Did you see Krzysztof's replies to this patch?
> >
> > Sounded like he was going to re-work it, which is why I left it.
>
> The only rework needed was to add "dt-bindings:" prefix in the subject.
> If you could add it while applying/amending commit, that would be great
> and spare me resend. Otherwise, let me know if you dropped this patch
> and expect a resend.
Sounds good:
Acked-by: Lee Jones <lee@kernel.org>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-12-08 11:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 13:15 [PATCH] leds: qcom,pm8058-led: Convert to DT schema Krzysztof Kozlowski
2022-12-01 13:17 ` Krzysztof Kozlowski
2022-12-02 8:07 ` Lee Jones
2022-12-02 0:08 ` Rob Herring
2022-12-02 8:30 ` Krzysztof Kozlowski
2022-12-07 20:11 ` Pavel Machek
2022-12-08 10:09 ` Lee Jones
2022-12-08 10:19 ` Krzysztof Kozlowski
2022-12-08 10:29 ` Pavel Machek
2022-12-08 10:57 ` Lee Jones [this message]
2022-12-07 20:12 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5HDKfC8Q1F7FXcI@google.com \
--to=lee@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=quic_c_skakit@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox