public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Petar Gligoric <petar.gligor@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Petar Gligoric <petar.gligoric@rohde-schwarz.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Hagen Paul Pfeifer <hagen@jauu.net>
Subject: Re: [PATCH v2 0/3] perf: introduce perf based task analyzer
Date: Thu, 8 Dec 2022 07:15:49 -0500	[thread overview]
Message-ID: <Y5HVdS3mlDruNyrl@debian> (raw)
In-Reply-To: <CAM9d7chLZVDg_-tnUh_qFYzchnpis-e7HYNDVM_OPjj_QXMeKQ@mail.gmail.com>

> > Thanks for the input! For this patchset we explicitly decided against
> > extending "perf sched timehist" - after some pros and cons. Mainly we
> > didn't want to break existing programs (which might parse the output of
> > perf sched) and also the goal of the task-analyzer is a bit different.
> > E.g what will follow as a follow-up patch, is to show IRQs visually
> > pleasing intermixed with tasks to show potential sources of task
> > latency. This will be offered as an option for the task-analyzer, but
> > would be too much functionality for "perf sched timehist". This was the
> > main reason why we decided against the extension.
> 
> Then you might want to add a new sub-command under perf sched.
> But I guess we can just add a new option for the different output
> format in the perf sched timehist.
> 
> Anyway, "perf script" is a generic tool not targeting specific events.
> This functionality requires sched_switch (and more?) then we need
> the record part to make sure the data has the events.  That's why
> it's natural to have it in perf sched IMHO.
> 
> Thanks,
> Namhyung

We assumed that python scripts should not only be used as a "generic tool".
There are a number of tools like flamegraph, netdev-times, dropmonitor and
other scripts that analyze and look at *very specific* events. The question is
rather, why should this be implemented in C? When using Python - with batteries
included - less code has to be written for the identical result, and it is less
error-prone than C (less technical debt). We have measured the performance,
even for very large perf.data files, and again we see no problems.

But maybe this should be clarified in principle! What do you say Arnaldo, Ian,
...?

Petar


  reply	other threads:[~2022-12-08 12:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 15:44 [PATCH v2 0/3] perf: introduce perf based task analyzer Petar Gligoric
2022-12-06 15:44 ` [PATCH v2 1/3] perf script: introduce " Petar Gligoric
2022-12-06 15:44 ` [PATCH v2 2/3] perf script: task-analyzer add csv support Petar Gligoric
2022-12-06 15:44 ` [PATCH v2 3/3] perf test: add new task-analyzer tests Petar Gligoric
2022-12-06 18:32 ` [PATCH v2 0/3] perf: introduce perf based task analyzer Namhyung Kim
2022-12-06 22:21   ` Petar Gligoric
2022-12-08  4:59     ` Namhyung Kim
2022-12-08 12:15       ` Petar Gligoric [this message]
2022-12-08 19:10         ` Namhyung Kim
2022-12-08 20:11           ` Petar Gligoric
2022-12-08 20:15             ` Namhyung Kim
2022-12-12 20:03               ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5HVdS3mlDruNyrl@debian \
    --to=petar.gligor@gmail.com \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=hagen@jauu.net \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=petar.gligoric@rohde-schwarz.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox