From: Jiri Pirko <jiri@resnulli.us>
To: Li Zetao <lizetao1@huawei.com>
Cc: kevin.curtis@farsite.co.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: farsync: Fix kmemleak when rmmods farsync
Date: Thu, 8 Dec 2022 13:44:26 +0100 [thread overview]
Message-ID: <Y5HcKlwQuzhpzZs9@nanopsycho> (raw)
In-Reply-To: <20221208120540.3758720-1-lizetao1@huawei.com>
Thu, Dec 08, 2022 at 01:05:40PM CET, lizetao1@huawei.com wrote:
>There are two memory leaks reported by kmemleak:
>
> unreferenced object 0xffff888114b20200 (size 128):
> comm "modprobe", pid 4846, jiffies 4295146524 (age 401.345s)
> hex dump (first 32 bytes):
> e0 62 57 09 81 88 ff ff e0 62 57 09 81 88 ff ff .bW......bW.....
> 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<ffffffff815bcd82>] kmalloc_trace+0x22/0x60
> [<ffffffff83d35c78>] __hw_addr_add_ex+0x198/0x6c0
> [<ffffffff83d3989d>] dev_addr_init+0x13d/0x230
> [<ffffffff83d1063d>] alloc_netdev_mqs+0x10d/0xe50
> [<ffffffff82b4a06e>] alloc_hdlcdev+0x2e/0x80
> [<ffffffffa016a741>] fst_add_one+0x601/0x10e0 [farsync]
> ...
>
> unreferenced object 0xffff88810b85b000 (size 1024):
> comm "modprobe", pid 4846, jiffies 4295146523 (age 401.346s)
> hex dump (first 32 bytes):
> 00 00 b0 02 00 c9 ff ff 00 70 0a 00 00 c9 ff ff .........p......
> 00 00 00 f2 00 00 00 f3 0a 00 00 00 02 00 00 00 ................
> backtrace:
> [<ffffffff815bcd82>] kmalloc_trace+0x22/0x60
> [<ffffffffa016a294>] fst_add_one+0x154/0x10e0 [farsync]
> [<ffffffff82060e83>] local_pci_probe+0xd3/0x170
> ...
>
>The root cause is traced to the netdev and fst_card_info are not freed
>when removes one fst in fst_remove_one(), which may trigger oom if
>repeated insmod and rmmod module.
>
>Fix it by adding free_netdev() and kfree() in fst_remove_one(), just as
>the operations on the error handling path in fst_add_one().
>
>Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
On top, may be worth ordering the cleanup in fst_remove_one() to be
aligned with the order in fst_add_one() error path.
next prev parent reply other threads:[~2022-12-08 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 12:05 [PATCH] net: farsync: Fix kmemleak when rmmods farsync Li Zetao
2022-12-08 12:44 ` Jiri Pirko [this message]
2022-12-12 9:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5HcKlwQuzhpzZs9@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kevin.curtis@farsite.co.uk \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox