From: Lee Jones <lee@kernel.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Subject: Re: [PATCH] mfd: Drop obsolete dependencies on COMPILE_TEST
Date: Thu, 8 Dec 2022 13:16:01 +0000 [thread overview]
Message-ID: <Y5HjkaWNF5/nTVTQ@google.com> (raw)
In-Reply-To: <20221122154134.58a7a18b@endymion.delvare>
On Tue, 22 Nov 2022, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
>
> As a minor optimization, this also lets us drop of_match_ptr(), as we
> now know what it will resolve to, we might as well save cpp some work.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Lee Jones <lee@kernel.org>
> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
> ---
> drivers/mfd/Kconfig | 16 ++++++++--------
> drivers/mfd/motorola-cpcap.c | 2 +-
> 2 files changed, 9 insertions(+), 9 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2022-12-08 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 14:41 [PATCH] mfd: Drop obsolete dependencies on COMPILE_TEST Jean Delvare
2022-12-08 13:16 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5HjkaWNF5/nTVTQ@google.com \
--to=lee@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=brgl@bgdev.pl \
--cc=cw00.choi@samsung.com \
--cc=j.neuschaefer@gmx.net \
--cc=jdelvare@suse.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox