From: Lee Jones <lee@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: rohm-bd*: Use dev_err_probe()
Date: Thu, 8 Dec 2022 13:53:27 +0000 [thread overview]
Message-ID: <Y5HsV41KCSEmWSNV@google.com> (raw)
In-Reply-To: <Y33lte0PKd2u6dyR@fedora>
On Wed, 23 Nov 2022, Matti Vaittinen wrote:
> The dev_err_probe() has (at least) following benefits over dev_err()
> when printing an error print for a failed function call at a device
> driver probe:
> - Omit error level print if error is 'EPRBE_DEFER'
> - Standardized print format for returned error
> - return the error value allowing shortening calls like:
>
> if (ret) {
> dev_err(...);
> return ret;
> }
>
> to
>
> if (ret)
> return dev_err_probe(...);
>
> Convert the ROHM BD71828, ROHM BD718x7 and ROHM BD9576 core drivers to
> use the dev_err_probe() when returned error is not hard-coded constant.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
> drivers/mfd/rohm-bd71828.c | 23 ++++++++++-------------
> drivers/mfd/rohm-bd718x7.c | 21 ++++++++-------------
> drivers/mfd/rohm-bd9576.c | 17 ++++++++---------
> 3 files changed, 26 insertions(+), 35 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2022-12-08 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 9:19 [PATCH] mfd: rohm-bd*: Use dev_err_probe() Matti Vaittinen
2022-12-08 13:53 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5HsV41KCSEmWSNV@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox