Re: [PATCH v5 4/8] dt-bindings: media: add bindings for TI DS90UB953

Tomi Valkeinen
2023-01-04T08:26:45Z

Hi Rob,

On 09/12/2022 23:27, Rob Herring wrote:
> On Thu, Dec 08, 2022 at 12:40:02PM +0200, Tomi Valkeinen wrote:
>> Add DT bindings for TI DS90UB953 FPDLink-3 Serializer.
>
> Seems like this and DS90UB913 binding could be combined. I couldn't spot
> a difference.

They are indeed quite similar, but there are a few diffs, especially
after fixing Laurent's review comments.

E.g, as the UB913 is a parallel video serializer and the UB953 is a
CSI-2 serializer, the input port on UB913 has 'pclk-sample' property but
UB953 has 'data-lanes' property. The descriptions differ also a bit for
the above mentioned difference.

The above points would still allow combining the bindings, though. But I
feel the UB913 is somewhat a different class of serializer device
compared to UB953 (and UB971 which the UB953's binding also supports),
so my gut feeling says it's better to keep them separate. But I don't
have much experience on maintaining such bindings, and, afaik, we could
always split the bindings later if needed.

So... Do you have a preference on either way? Or maybe we can come back
to this after I send the next version with the updates.

> In the subjects, drop 'binding for'. The prefix says this is a binding.
> Maybe add 'Serializer'.

Ok.

Tomi