Re: [PATCH v5 3/8] dt-bindings: media: add bindings for TI DS90UB913

Laurent Pinchart
2022-12-11T17:21:31Z

I missed one issue.

On Sun, Dec 11, 2022 at 07:13:10PM +0200, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Thu, Dec 08, 2022 at 12:40:01PM +0200, Tomi Valkeinen wrote:
> > Add DT bindings for TI DS90UB913 FPDLink-3 Serializer.
> >
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> > ---
> > .../bindings/media/i2c/ti,ds90ub913.yaml | 121 ++++++++++++++++++
> > 1 file changed, 121 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml
> > new file mode 100644
> > index 000000000000..3a5b34c6bb64
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub913.yaml
> > @@ -0,0 +1,121 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/ti,ds90ub913.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Texas Instruments DS90UB913 FPD-Link 3 Serializer
>
> I think TI consistently writes it "FPD-Link III". If you rename it,
> please do so through the whole series.
>
> > +
> > +maintainers:
> > + - Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> > +
> > +description:
> > + The TI DS90UB913 is an FPD-Link 3 video serializer for parallel video.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - ti,ds90ub913a-q1
>
> Is the -q1 suffix needed, are there other variants ?
>
> > +
> > + '#gpio-cells':
> > + const: 2
> > +
> > + gpio-controller: true
> > +
> > + clocks:
> > + maxItems: 1
> > + description:
> > + Reference clock connected to the CLKIN pin.
> > +
> > + clock-names:
> > + items:
> > + - const: clkin
> > +
> > + '#clock-cells':
> > + const: 0
> > +
> > + ports:
> > + $ref: /schemas/graph.yaml#/properties/ports
> > +
> > + properties:
> > + port@0:
> > + $ref: /schemas/graph.yaml#/$defs/port-base
> > + unevaluatedProperties: false
> > + description: CSI-2 input port

This should be "Parallel input port".

> > +
> > + properties:
> > + endpoint:
> > + $ref: /schemas/media/video-interfaces.yaml#
> > + unevaluatedProperties: false

Should at least the bus-width property be mandatory, as the device
supports both 10- and 12-bit inputs ?

> > +
> > + port@1:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + unevaluatedProperties: false
> > + description: FPD-Link 3 output port
>
> I'd add
>
> required:
> - port@0
> - port@1
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > +
> > + i2c:
> > + $ref: /schemas/i2c/i2c-controller.yaml#
> > + unevaluatedProperties: false
> > +
> > +required:
> > + - compatible
> > + - '#gpio-cells'
> > + - gpio-controller
> > + - '#clock-cells'
> > + - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + serializer {
> > + compatible = "ti,ds90ub913a-q1";
> > +
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > +
> > + clocks = <&clk_cam_48M>;
> > + clock-names = "clkin";
> > +
> > + #clock-cells = <0>;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 {
> > + reg = <0>;
> > + ub913_in: endpoint {
> > + remote-endpoint = <&sensor_out>;
> > + };
> > + };
> > +
> > + port@1 {
> > + reg = <1>;
> > + endpoint {
> > + remote-endpoint = <&deser_fpd_in>;
> > + };
> > + };
> > + };
> > +
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + sensor@48 {
> > + compatible = "aptina,mt9v111";
> > + reg = <0x48>;
> > +
> > + clocks = <&fixed_clock>;
> > +
> > + port {
> > + sensor_out: endpoint {
> > + remote-endpoint = <&ub913_in>;
> > + };
> > + };
> > + };
> > + };
> > + };
> > +...

--
Regards,

Laurent Pinchart