Re: [PATCH v5 1/8] i2c: core: let adapters be notified of client attach/detach

Tomi Valkeinen
2022-12-08T16:10:48Z

On 08/12/2022 14:30, Andy Shevchenko wrote:
> On Thu, Dec 08, 2022 at 12:39:59PM +0200, Tomi Valkeinen wrote:
>> From: Luca Ceresoli <luca@lucaceresoli.net>
>>
>> An adapter might need to know when a new device is about to be
>> added. This will soon bee needed to implement an "I2C address
>> translator" (ATR for short), a device that propagates I2C transactions
>> with a different slave address (an "alias" address). An ATR driver
>> needs to know when a slave is being added to find a suitable alias and
>> program the device translation map.
>>
>> Add an attach/detach callback pair to allow adapter drivers to be
>> notified of clients being added and removed.
>
> ...
>
>> + if (adap->attach_ops &&
>> + adap->attach_ops->attach_client &&
>> + adap->attach_ops->attach_client(adap, info, client) != 0)
>> + goto out_remove_swnode;
>
> With a temporary variable it becomes better
>

Ok.

Tomi