Re: [PATCH v5 0/8] i2c-atr and FPDLink

Tomi Valkeinen
2022-12-08T14:41:12Z

Hi Andy,

On 08/12/2022 14:26, Andy Shevchenko wrote:
> On Thu, Dec 08, 2022 at 12:42:13PM +0200, Tomi Valkeinen wrote:
>> On 08/12/2022 12:39, Tomi Valkeinen wrote:
>
> ...
>
>> +#include <linux/fwnode.h>
>> #include <linux/i2c-atr.h>
>> #include <linux/i2c.h>
>> #include <linux/kernel.h>
>> #include <linux/module.h>
>> #include <linux/mutex.h>
>> -#include <linux/of.h>
>> #include <linux/slab.h>
>
> + Blank line here?
>

There is a blank line there.

>> +#define ATR_MAX_ADAPTERS 99 /* Just a sanity limit */
>> +#define ATR_MAX_SYMLINK_LEN 16 /* Longest name is 10 chars: "channel-99" */
>
> ...
>
>> + u16 *new_buf;
>> +
>> + new_buf = kmalloc_array(num, sizeof(chan->orig_addrs[0]),
>> + GFP_KERNEL);
>
> new_buf = kmalloc_array(num, sizeof(*new_buf), GFP_KERNEL);
>
> ?

Yes, I think that looks better here.

>> + if (!new_buf)
>> return -ENOMEM;
>
> ...
>
>> struct i2c_atr_cli2alias_pair *c2a;
>> - u16 alias_id = 0;
>> - int ret = 0;
>> + u16 alias_id;
>> + int ret;
>
> Is it mangled or it's missing blank line here?

Also here there is a blank line. Is the mail somehow mangled on your
side? On lore it looks fine:

https://lore.kernel.org/all/c5eac6a6-f44b-ddd0-d27b-ccbe01498ae9@ideasonboard.com/

>> c2a = kzalloc(sizeof(*c2a), GFP_KERNEL);
>> if (!c2a)
>
> ...
>
>> struct device;
>> struct i2c_atr;
>> +struct fwnode_handle;
>
> Order?

Yep, I'll fix.

> ...
>
>> /**
>> - * Helper to add I2C ATR features to a device driver.
>> + * struct i2c_atr - Represents the I2C ATR instance
>> */
>
> This is incomplete. Have you run kernel doc validator against this file?

What's kernel doc validator? Do you mean that it's incomplete and kernel
doc doesn't work correctly, or that there should be more information here?

I don't get any errors/warnings from any tool I have used. But I agree
it looks a bit odd with only the name of the struct in the doc.

Tomi