Re: [PATCH 2/4] Documentation: amd_pstate: Move amd_pstate param to alphabetical order

Wyes Karny
2022-12-09T06:44:22Z

Hi Bagas Sanjaya,

On 12/8/2022 8:12 AM, Bagas Sanjaya wrote:
> On Wed, Dec 07, 2022 at 03:46:46PM +0000, Wyes Karny wrote:
>> + amd_pstate= [X86]
>> + disable
>> + Do not enable amd_pstate as the default
>> + scaling driver for the supported processors
>> + passive
>> + Use amd_pstate as a scaling driver, driver requests a
>> + desired performance on this abstract scale and the power
>> + management firmware translates the requests into actual
>> + hardware states (core frequency, data fabric and memory
>> + clocks etc.)
>
> Device drivers request certain performance level?

What about the below wording?

""

passive
Use amd_pstate with passive mode as a scaling driver.
In this mode autonomous selection is disabled.
Driver requests a desired performance level and PMFW
tires to match the same performance level (if it is
satisfied by guaranteed performance level).

""

Perry, let me know if it looks fine to you?

>
>> + guided
>> + Activate guided autonomous mode. Driver requests minimum
>> + performance and maximum performance and the PMFW autonomously
>> + selects frequencies in this range.
>
> Same here.

I'll rewrite this as:

guided
Activate guided autonomous mode. Driver requests minimum and
maximum performance level and the PMFW autonomously
selects a performance level in this range and appropriate
to the current workload.

>
> Thanks.
>

--
Thanks & Regards,
Wyes