From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Richard Fitzgerald <rf@opensource.cirrus.com>,
wsa@kernel.org, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com, jsd@semihalf.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH] i2c: designware: Fix unbalanced suspended flag
Date: Fri, 9 Dec 2022 16:04:12 +0200 [thread overview]
Message-ID: <Y5NAXP718ZS2CZUb@smile.fi.intel.com> (raw)
In-Reply-To: <e9d113fb-5cd1-d93d-3d8f-fa9c1e55a8e2@redhat.com>
On Fri, Dec 09, 2022 at 01:15:21PM +0100, Hans de Goede wrote:
> On 12/9/22 12:40, Richard Fitzgerald wrote:
...
> Did you add printk messages to the suspend/resume callbacks of
> i2c-designware-platdrv.c which show the system suspend callback
> being called but not the system resume one ?
Side note: It's better to use ftrace for that, less invasive time-wise.
...
> Did you add a printk to both the if + else paths
> and have you ever seen the controller not get
> resumed with this test added ?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-12-09 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 11:40 [PATCH] i2c: designware: Fix unbalanced suspended flag Richard Fitzgerald
2022-12-09 12:15 ` Hans de Goede
2022-12-09 12:29 ` Richard Fitzgerald
2022-12-09 13:36 ` Richard Fitzgerald
2022-12-09 14:22 ` Richard Fitzgerald
2022-12-09 18:16 ` Hans de Goede
2022-12-09 13:40 ` Richard Fitzgerald
2022-12-09 14:04 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5NAXP718ZS2CZUb@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox