From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF60C4332F for ; Fri, 9 Dec 2022 14:04:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229811AbiLIOEY (ORCPT ); Fri, 9 Dec 2022 09:04:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiLIOET (ORCPT ); Fri, 9 Dec 2022 09:04:19 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 364146C731; Fri, 9 Dec 2022 06:04:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670594658; x=1702130658; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xRDLAgO0B0bki/4vlcUzPPWeDY+4XUKMNAA2OHnB5WI=; b=hgww7odzgNhDbqQfsW4qopKa2e69Upb9NZXuOz7yh9HHJ/UC3vmQ29TC N2U9I/XGq9rzo7AAuB5XKpXIo+sjDcOxWmvDk7/Abuk3nqdgRCg8vXRw9 tHRtw2DjenpvKf17CiaNKljLPEt3wGHK4vj6rLTvK6EX5f5hzoti85QeL EpR7GBnuRbJIli7LZ1w0MaRAbSp+6sru4T7ICPI/m9OnZCSrxiD2qJB7H Hh/6T+hLbK1/yKaSr5M49eygbNCyfp/Jufq+DYFov6qGbhu5o9nWkFLYK kxm4VxDSIDVcRRcE8vjga0GVyqTbsRBkX+FtXss6AcSr/j9WukWA48gBt A==; X-IronPort-AV: E=McAfee;i="6500,9779,10556"; a="305105839" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="305105839" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2022 06:04:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10556"; a="678159905" X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="678159905" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 09 Dec 2022 06:04:14 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p3dz3-006yRX-0f; Fri, 09 Dec 2022 16:04:13 +0200 Date: Fri, 9 Dec 2022 16:04:12 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Richard Fitzgerald , wsa@kernel.org, jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, jsd@semihalf.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH] i2c: designware: Fix unbalanced suspended flag Message-ID: References: <20221209114034.18025-1-rf@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 09, 2022 at 01:15:21PM +0100, Hans de Goede wrote: > On 12/9/22 12:40, Richard Fitzgerald wrote: ... > Did you add printk messages to the suspend/resume callbacks of > i2c-designware-platdrv.c which show the system suspend callback > being called but not the system resume one ? Side note: It's better to use ftrace for that, less invasive time-wise. ... > Did you add a printk to both the if + else paths > and have you ever seen the controller not get > resumed with this test added ? -- With Best Regards, Andy Shevchenko