From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E649C4332F for ; Fri, 9 Dec 2022 16:16:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbiLIQQH (ORCPT ); Fri, 9 Dec 2022 11:16:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbiLIQPt (ORCPT ); Fri, 9 Dec 2022 11:15:49 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D8C480A18 for ; Fri, 9 Dec 2022 08:15:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D8089B828AE for ; Fri, 9 Dec 2022 16:15:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C072C433EF; Fri, 9 Dec 2022 16:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670602545; bh=NGcwPc7DMb4fS1KDuZj68I6Cptg4ZJqA+izWttWbmAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SCQwV8ijgCXO7FkENkMJMWTSZrgmpOi8U39CuumENJVEg93wiejFAl/J1eGxs1S3F AByRw28XV0Wuz/PPi+44uRSIWvmZzHl311bQkaDKoadDlu7ycsp7UOhxDHWwChy7y/ FBB9gBGwJI3Cao1T0ci66Zbnx7hoyyXNJYxWSxZY= Date: Fri, 9 Dec 2022 17:15:42 +0100 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de, "Rafael J. Wysocki" Subject: Re: [PATCH] platform: Provide a remove callback that returns no value Message-ID: References: <20221209150914.3557650-1-u.kleine-koenig@pengutronix.de> <20221209155207.pyugk2dhpyht5gph@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221209155207.pyugk2dhpyht5gph@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 09, 2022 at 04:52:07PM +0100, Uwe Kleine-König wrote: > Hello Greg, > > On Fri, Dec 09, 2022 at 04:21:30PM +0100, Greg Kroah-Hartman wrote: > > On Fri, Dec 09, 2022 at 04:09:14PM +0100, Uwe Kleine-König wrote: > > > struct platform_driver::remove returning an integer made driver authors > > > expect that returning an error code was proper error handling. However > > > the driver core ignores the error and continues to remove the device > > > because there is nothing the core could do anyhow and reentering the > > > remove callback again is only calling for trouble. > > > > > > So this is an source for errors typically yielding resource leaks in the > > > error path. > > > > > > As there are too many platform drivers to neatly convert them all to > > > return void in a single go, do it in several steps after this patch: > > > > > > a) Convert all drivers to implement .remove_new() returning void instead > > > of .remove() returning int; > > > b) Change struct platform_driver::remove() to return void and so make > > > it identical to .remove_new(); > > > c) Change all drivers back to .remove() now with the better prototype; > > > > Change c) seems like it will be just as much work as a), right? > > Yeah, but c) should be trivially doable per subsystem using coccinelle. > So my plan is to do a) per subsystem with one patch per driver and c) > with one patch per subsystem. > > > Who is going to do the work of the conversion to this new prototype? > > I'll be glad to take this, but I don't want to see a half-finished > > conversion happen and us stuck with a "new" and "old" call, as that > > would just be a mess. > > The idea is that this becomes my new pet project once > https://lore.kernel.org/lkml/20221118224540.619276-1-uwe@kleine-koenig.org > is complete. :-) > > I intend to work on that once the patch under discussion is included in > an -rc1. Ok, I'll wait to queue this up to my tree until after 6.2-rc1 is out, thanks. greg k-h