From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Vipin Sharma <vipinsh@google.com>
Cc: linux-kernel@vger.kernel.org, paulo.miguel.almeida.rodenas@gmail.com
Subject: [PATCH] scripts/tags.sh: allow only selected directories to be indexed
Date: Sat, 10 Dec 2022 08:18:38 +1300 [thread overview]
Message-ID: <Y5OKDvbGk4Kro6MK@mail.google.com> (raw)
It's common for drivers that share same physical components to also
duplicate source code (or at least portions of it). A good example is
both drivers/gpu/drm/amdgpu/* and drivers/gpu/drm/radeon/* have a header
file called atombios.h.
While their contents aren't the same, a lot of their structs have
the exact same names which makes navigating through the code base a bit
messy as cscope will show up 'references' across drivers which aren't
exactly correct.
This patch makes it possible for the devs to specify which folders
they want to include as part of the find_other_sources function if a
makefile variable OTHERSRCDIRS is present, otherwise the original
behaviour is kept.
Example:
make ARCH=x86 OTHERSRCDIRS=drivers/gpu/drm/radeon,tools cscope
Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
---
scripts/tags.sh | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/scripts/tags.sh b/scripts/tags.sh
index e137cf15aae9..958c07c4ac4a 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -59,12 +59,17 @@ find_include_sources()
}
# find sources in rest of tree
-# we could benefit from a list of dirs to search in here
find_other_sources()
{
- find ${tree}* $ignore \
- \( -path ${tree}include -o -path ${tree}arch -o -name '.tmp_*' \) -prune -o \
- -name "$1" -not -type l -print;
+ find_def_params="-name $1 -not -type l -print"
+ if [ -n "${OTHERSRCDIRS}" ]; then
+ exp_src_dirs=$(sed 's/,/ /g' <<< ${OTHERSRCDIRS})
+ find ${exp_src_dirs} ${ignore} ${find_def_params};
+ else
+ find ${tree}* ${ignore} \
+ \( -path ${tree}include -o -path ${tree}arch -o -name '.tmp_*' \) \
+ -prune -o ${find_def_params};
+ fi
}
find_sources()
--
2.38.1
next reply other threads:[~2022-12-09 19:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 19:18 Paulo Miguel Almeida [this message]
2022-12-10 20:31 ` [PATCH] scripts/tags.sh: allow only selected directories to be indexed Vipin Sharma
2022-12-10 21:32 ` Paulo Miguel Almeida
2022-12-10 23:02 ` [PATCH v2] scripts/tags.sh: choose which directories to exclude from being indexed Paulo Miguel Almeida
2022-12-11 4:21 ` Bagas Sanjaya
2022-12-11 20:27 ` Paulo Miguel Almeida
2022-12-12 21:27 ` Vipin Sharma
2022-12-12 21:59 ` Paulo Miguel Almeida
2022-12-12 22:32 ` Vipin Sharma
2022-12-13 2:03 ` Paulo Miguel Almeida
2022-12-13 20:26 ` [PATCH v3] " Paulo Miguel Almeida
2022-12-14 17:40 ` Vipin Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5OKDvbGk4Kro6MK@mail.google.com \
--to=paulo.miguel.almeida.rodenas@gmail.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox