Re: [PATCH v2 2/4] workingset: refactor LRU refault to expose refault recency check

Matthew Wilcox
2022-12-06T15:23:08Z

On Mon, Dec 05, 2022 at 09:51:38AM -0800, Nhat Pham wrote:
> +static bool lru_gen_test_recent(void *shadow, bool file, int *memcgid,
> + struct pglist_data **pgdat, unsigned long *token, bool *workingset)

This line needs more than one tab indent. I tend to use two tabs,
others try to line up the parameters with the opening '('. But
one tab is too visually similar to the body of the function.

> rcu_read_lock();
>
> memcg = folio_memcg_rcu(folio);
> +
> + if (!lru_gen_test_recent(shadow, type, &memcg_id, &pgdat, &token,
> + &workingset))

Similarly here. &workingset looks like it's part of the body of the if,
not part of the function call.

> + goto unlock;
> +
> if (memcg_id != mem_cgroup_id(memcg))
> goto unlock;
>