From: Andrew Lunn <andrew@lunn.ch>
To: Piergiorgio Beruto <piergiorgio.beruto@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [PATCH v5 net-next 1/5] net/ethtool: add netlink interface for the PLCA RS
Date: Sun, 11 Dec 2022 12:12:23 +0100 [thread overview]
Message-ID: <Y5W7F0mX1VvRsWjD@lunn.ch> (raw)
In-Reply-To: <Y5IY6FLtndqXqzMn@gvm01>
> Given what I just said, what would you suggest to do?
I would return just the version part, not the whole register contents.
The nice thing about netlink is you can add extra attributes without
breaking the ABI. If that 0xA ever gains a meaning and more values, an
attribute for it can be added.
Andrew
next prev parent reply other threads:[~2022-12-11 11:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 0:00 [PATCH v5 net-next 0/5] add PLCA RS support and onsemi NCN26000 Piergiorgio Beruto
2022-12-07 0:01 ` [PATCH v5 net-next 1/5] net/ethtool: add netlink interface for the PLCA RS Piergiorgio Beruto
2022-12-07 3:50 ` Jakub Kicinski
2022-12-07 13:08 ` Piergiorgio Beruto
2022-12-07 14:16 ` Andrew Lunn
2022-12-07 15:42 ` Piergiorgio Beruto
2022-12-07 16:06 ` Andrew Lunn
2022-12-07 16:17 ` Piergiorgio Beruto
2022-12-07 17:48 ` Andrew Lunn
2022-12-07 18:44 ` Piergiorgio Beruto
2022-12-07 19:25 ` Andrew Lunn
2022-12-08 17:03 ` Piergiorgio Beruto
2022-12-11 11:12 ` Andrew Lunn [this message]
2022-12-11 11:43 ` Piergiorgio Beruto
2022-12-07 15:49 ` Piergiorgio Beruto
2022-12-08 2:12 ` Jakub Kicinski
2022-12-08 2:10 ` Jakub Kicinski
2022-12-08 14:48 ` Piergiorgio Beruto
2022-12-07 0:01 ` [PATCH v5 net-next 2/5] drivers/net/phy: add the link modes for the 10BASE-T1S Ethernet PHY Piergiorgio Beruto
2022-12-07 0:02 ` [PATCH v5 net-next 3/5] drivers/net/phy: add connection between ethtool and phylib for PLCA Piergiorgio Beruto
2022-12-07 0:02 ` [PATCH v5 net-next 4/5] drivers/net/phy: add helpers to get/set PLCA configuration Piergiorgio Beruto
2022-12-07 0:02 ` [PATCH v5 net-next 5/5] drivers/net/phy: add driver for the onsemi NCN26000 10BASE-T1S PHY Piergiorgio Beruto
2022-12-07 0:43 ` [PATCH v5 net-next 0/5] add PLCA RS support and onsemi NCN26000 Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5W7F0mX1VvRsWjD@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox