From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0F46C4332F for ; Sun, 11 Dec 2022 11:33:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230220AbiLKLdm (ORCPT ); Sun, 11 Dec 2022 06:33:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230209AbiLKLdj (ORCPT ); Sun, 11 Dec 2022 06:33:39 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 755B0BC3B for ; Sun, 11 Dec 2022 03:33:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id C1694CE0B1A for ; Sun, 11 Dec 2022 11:33:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 931BFC433EF; Sun, 11 Dec 2022 11:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670758414; bh=yXxiBhh4kn8sPgZWQf/bxgFMPGx3iwySDzRuKdth0gQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f/GE4d4nEldb5laZOZUau/uWRTOeoyVvI8z4zwkpGd6wyxgQvpMBkg1cHSkqBDuG5 Ertaw8WfJ4oiQtYsQedg75lcpb3DifuYCyLmqjPr0hogcgrF2G7Vnd6/mb+H4M/QO4 eICd3mi+/ko3G1AbdijxRQF6NEA8At7D9Ce/LY2Q= Date: Sun, 11 Dec 2022 12:33:30 +0100 From: Greg Kroah-Hartman To: Dalvin Aiguobas Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH] staging: wlan-ng: fix checkpatch error for spinlock Message-ID: References: <20221211105649.GA4683@koolguy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 11, 2022 at 12:06:04PM +0100, Greg Kroah-Hartman wrote: > On Sun, Dec 11, 2022 at 11:56:49AM +0100, Dalvin Aiguobas wrote: > > Checkpatch Styleproblem fixed by adding comment. > > > > Signed-off-by: Dalvin > > --- > > drivers/staging/wlan-ng/hfa384x.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h > > index 0611e37df6ac..ad117d570bb6 100644 > > --- a/drivers/staging/wlan-ng/hfa384x.h > > +++ b/drivers/staging/wlan-ng/hfa384x.h > > @@ -1171,6 +1171,7 @@ struct hfa384x_usbctlx { > > }; > > > > struct hfa384x_usbctlxq { > > + /* lock: Protect structure fields */ Also, does this comment really make sense? To properly document a lock takes a bit more text, if you read this would it help out in understanding the code any? thanks, greg k-h