Re: [PATCH 0/5] perf: cs-etm: Print auxtrace info even if OpenCSD isn't linked

Arnaldo Carvalho de Melo
2022-12-12T19:51:00Z

Em Mon, Dec 12, 2022 at 03:55:08PM +0000, James Clark escreveu:
> The auxtrace info header can be useful for debugging, and at the
> moment it's possible to record a file without OpenCSD linked but
> not view the header even though it should be possible to do.
>
> This patchset tidies up some of the related functions and
> improves some of the error messages before making the above
> possible in the last commit.
>
> Testing done:
>
> * Compiled on x86 and Arm both with and without CORESIGHT=1
> * Ran the Coresight tests
>
> Applies to perf/core (0c3852adae8)

Thanks, applied.

- Arnaldo

> James Clark (5):
> perf: cs-etm: Print unknown header version as an error
> perf: cs-etm: Remove unused stub methods
> perf: cs-etm: Tidy up auxtrace info header printing
> perf: cs-etm: Cleanup cs_etm__process_auxtrace_info()
> perf: cs-etm: Print auxtrace info even if OpenCSD isn't linked
>
> tools/perf/util/Build | 1 +
> tools/perf/util/cs-etm-base.c | 174 ++++++++++++++++++++++++++++
> tools/perf/util/cs-etm.c | 208 +++-------------------------------
> tools/perf/util/cs-etm.h | 46 ++------
> 4 files changed, 200 insertions(+), 229 deletions(-)
> create mode 100644 tools/perf/util/cs-etm-base.c
>
> --
> 2.25.1

--

- Arnaldo