From: Greg KH <gregkh@linuxfoundation.org>
To: Puma Hsu <pumahsu@google.com>
Cc: mka@chromium.org, dianders@chromium.org, albertccwang@google.com,
raychi@google.com, howardyen@google.com, leejj@google.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: core: add implementations for usb suspend/resume hooks
Date: Wed, 14 Dec 2022 09:21:21 +0100 [thread overview]
Message-ID: <Y5mHgYNflldQDkdi@kroah.com> (raw)
In-Reply-To: <20221214070650.703793-3-pumahsu@google.com>
On Wed, Dec 14, 2022 at 03:06:50PM +0800, Puma Hsu wrote:
> + /*
> + * Note: Our private driver provides APIs to know the device is in audio playback
> + * or capture.
> + *
> + * usb_playback = usb_audio_playback_enabled();
> + * usb_capture = usb_audio_capture_enabled();
> + */
There is no such thing as a "private driver" in Linux, sorry, you know
this. Submit the real code please, otherwise this is just wasting
everyone's time :(
greg k-h
next prev parent reply other threads:[~2022-12-14 8:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 7:06 [PATCH 0/2] add vendor hooks for usb suspend and resume Puma Hsu
2022-12-14 7:06 ` [PATCH 1/2] usb: core: add vendor hook " Puma Hsu
2022-12-14 7:20 ` Puma Hsu
2022-12-14 7:36 ` Christoph Hellwig
2022-12-14 8:20 ` Greg KH
2022-12-14 9:38 ` kernel test robot
2022-12-14 9:38 ` kernel test robot
2022-12-14 10:59 ` kernel test robot
2022-12-14 7:06 ` [PATCH 2/2] usb: core: add implementations for usb suspend/resume hooks Puma Hsu
2022-12-14 8:21 ` Greg KH [this message]
2022-12-14 9:48 ` kernel test robot
2022-12-19 12:32 ` kernel test robot
2022-12-14 8:17 ` [PATCH 0/2] add vendor hooks for usb suspend and resume Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5mHgYNflldQDkdi@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=albertccwang@google.com \
--cc=dianders@chromium.org \
--cc=howardyen@google.com \
--cc=leejj@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=pumahsu@google.com \
--cc=raychi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox