From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, bp@alien8.de, x86@kernel.org,
hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: lib: Separate instruction decoder MMIO type from MMIO trace
Date: Wed, 14 Dec 2022 13:32:18 -0700 [thread overview]
Message-ID: <Y5oy0vwZQAwzkDkr@zx2c4.com> (raw)
In-Reply-To: <20221214195629.GA15255@ranerica-svr.sc.intel.com>
On Wed, Dec 14, 2022 at 11:56:29AM -0800, Ricardo Neri wrote:
> > @@ -347,7 +347,7 @@ static int handle_mmio(struct pt_regs *regs, struct ve_info *ve)
> > unsigned long *reg, val, vaddr;
> > char buffer[MAX_INSN_SIZE];
> > struct insn insn = {};
> > - enum mmio_type mmio;
> > + enum insn_mmio_type mmio;
>
> It would be good to preserve the reverse fir order in the variable
> declarations.
>
> > - enum mmio_type mmio;
> > + enum insn_mmio_type mmio;
>
> Same here.
Maintaining reverse Christmas trees would be in the holiday spirit,
after all. I'll send a v2.
Jason
next prev parent reply other threads:[~2022-12-14 20:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 21:02 [PATCH] x86: lib: Separate instruction decoder MMIO type from MMIO trace Jason A. Donenfeld
2022-12-14 19:56 ` Ricardo Neri
2022-12-14 20:32 ` Jason A. Donenfeld [this message]
2022-12-14 20:34 ` [PATCH v2] " Jason A. Donenfeld
2022-12-14 21:30 ` Ricardo Neri
2022-12-16 20:13 ` Jason A. Donenfeld
2023-01-02 14:49 ` Jason A. Donenfeld
2023-01-02 15:30 ` Borislav Petkov
2023-01-02 15:59 ` Jason A. Donenfeld
2023-01-02 16:12 ` Borislav Petkov
2023-01-02 16:14 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5oy0vwZQAwzkDkr@zx2c4.com \
--to=jason@zx2c4.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox