From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5257EC4332F for ; Wed, 14 Dec 2022 20:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229619AbiLNUgj (ORCPT ); Wed, 14 Dec 2022 15:36:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229889AbiLNUf6 (ORCPT ); Wed, 14 Dec 2022 15:35:58 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A20D186E8 for ; Wed, 14 Dec 2022 12:32:31 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 245DDB81A29 for ; Wed, 14 Dec 2022 20:32:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D105C433EF; Wed, 14 Dec 2022 20:32:27 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="osp9pmAa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1671049945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wC3DK+YgPQ0ttmctrXPD0kFnokQIXCIWlQkz/+5zs88=; b=osp9pmAaLeaEtVc0TwsBqcNo3tuta3lIsUC5wP8EJ6F0nLDAtQAE3rCg/v5W+VpTxzRMZS +3NDvgIlfLEYW92bs+FQ6thKSq1dxwTpfhFG7X0AtwerHsqD5Ae/wHQvgn17IHu3g2faf9 VBRDFcdEFAIzChH/oPx+OjS9NdtVYp4= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id ff4d9f61 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 14 Dec 2022 20:32:24 +0000 (UTC) Date: Wed, 14 Dec 2022 13:32:18 -0700 From: "Jason A. Donenfeld" To: Ricardo Neri Cc: tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: lib: Separate instruction decoder MMIO type from MMIO trace Message-ID: References: <20221212210254.2559995-1-Jason@zx2c4.com> <20221214195629.GA15255@ranerica-svr.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221214195629.GA15255@ranerica-svr.sc.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2022 at 11:56:29AM -0800, Ricardo Neri wrote: > > @@ -347,7 +347,7 @@ static int handle_mmio(struct pt_regs *regs, struct ve_info *ve) > > unsigned long *reg, val, vaddr; > > char buffer[MAX_INSN_SIZE]; > > struct insn insn = {}; > > - enum mmio_type mmio; > > + enum insn_mmio_type mmio; > > It would be good to preserve the reverse fir order in the variable > declarations. > > > - enum mmio_type mmio; > > + enum insn_mmio_type mmio; > > Same here. Maintaining reverse Christmas trees would be in the holiday spirit, after all. I'll send a v2. Jason